Problem with prepared emails

Are you an Editor, Author, or Journal Manager in need of help? Want to talk to us about workflow issues? This is your forum.

Moderators: jmacgreg, michael, vgabler, John

Forum rules
The Public Knowledge Project Support Forum is moving to http://forum.pkp.sfu.ca

This forum will be maintained permanently as an archived historical resource, but all new questions should be added to the new forum. Questions will no longer be monitored on this old forum after March 30, 2015.
RickMath
Posts: 264
Joined: Fri Feb 27, 2009 12:30 am

Re: Problem with prepared emails

Postby RickMath » Mon May 17, 2010 2:02 pm

:D :D :D
James

I was able to get it working. Now all decisions and prepared emails are aligned.

Here is what I did.

The lines in the patch for Bug 3861
+ $decisionTemplateMap = array(
+ SUBMISSION_EDITOR_DECISION_ACCEPT => 'EDITOR_DECISION_ACCEPT',
+ SUBMISSION_EDITOR_DECISION_PENDING_REVISIONS => 'EDITOR_DECISION_REVISIONS',
+ SUBMISSION_EDITOR_DECISION_RESUBMIT => 'EDITOR_DECISION_RESUBMIT',
+ SUBMISSION_EDITOR_DECISION_DECLINE => 'EDITOR_DECISION_DECLINE'
+ );
+
+ $decisions = $sectionEditorSubmission->getDecisions();
+ $decisions = array_pop($decisions); // Rounds
+ $decision = (int) array_pop($decisions);
+
+ $email = new ArticleMailTemplate(
+ $sectionEditorSubmission,
+ isset($decisionTemplateMap[$decision])?$decisionTemplateMap[$decision]:null
+ );


Were changed to lines from Revision 1.189 in the CVS file. These are
$decisionTemplateMap = array(
SUBMISSION_EDITOR_DECISION_ACCEPT => 'EDITOR_DECISION_ACCEPT',
SUBMISSION_EDITOR_DECISION_PENDING_REVISIONS => 'EDITOR_DECISION_REVISIONS',
SUBMISSION_EDITOR_DECISION_RESUBMIT => 'EDITOR_DECISION_RESUBMIT',
SUBMISSION_EDITOR_DECISION_DECLINE => 'EDITOR_DECISION_DECLINE'
);

$decisions = $sectionEditorSubmission->getDecisions();
$decisions = array_pop($decisions); // Rounds
$decision = array_pop($decisions);
$decisionConst = $decision?$decision['decision']:null;

$email = new ArticleMailTemplate(
$sectionEditorSubmission,
isset($decisionTemplateMap[$decisionConst])?$decisionTemplateMap[$decisionConst]:null
);


Now everything seems to be working just fine. I have tested several of our submissions and each one of the Notify Author items was correct. I have not tested the Include Peer Reviews. The only thing that I would suggest to others is that the prepared email templates be edited for each individual journal as we all have our preferences.

Thanks. Glad I discovered this. Again KUDOS to the PKP team. :D

Rick


Return to “OJS Editorial Support and Discussion”

Who is online

Users browsing this forum: Bing [Bot] and 1 guest