PKP Bugzilla – Bug 8407
Active review count on reviewer selection page incorrect
Last modified: 2013-12-18 09:24:36 PST
We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.
Created attachment 3954 [details]
Alters the incomplete count query and the query used to sort by various columns, active count included.
The reviewer selection page that is presented to an editor contains a table of potential reviewers and a count of active reviews for each. This active review count is wrong - it includes reviews that have been declined by a reviewer as well as articles that have been declined or archived and the reviewer hasn't yet completed their review.
Jason, I think you were reviewing this entry, correct?
It took some doing, but I was able to test these query modifications for compliance against SQL-92 and SQL-99. If we're cool with using != for comparison tests (the a.status test), which is valid in Postgres, then the patch looks good. For standard compliance, we'd need to use <> instead.
I can commit Chris' work if that's fine, Alec.
Better to use <> -- OTOH that's what we generally use. But otherwise, please go for it.
tweak made, committed. Closing. Thanks, Chris!
fix active review counts on reviewer selection page
*** Bug 8519 has been marked as a duplicate of this bug. ***