PKP Bugzilla – Bug 6672
ReviewAssignmentDAO->getCompletedReviewCounts() no longer gets called, and should be removed
Last modified: 2012-09-21 14:43:21 PDT
We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.
The patch for bug #6263 removes the only line that made use of classes/submission/reviewAssignment/ReviewAssignmentDAO->getCompletedReviewCounts() - it also generated incorrect values, and is best removed to prevent dead code.
Created attachment 3539 [details]
this patch removes ReviewAssignmentDAO->getCompletedReviewCounts
What about getCompletedReviewCountsForReviewForms? We were talking about that as well in bug #6263.
technically getCompletedReviewCountsForReviewForms wasn't orphaned by any work in 6263, so perhaps a better idea is to remove it as part of a "dead code removal" ticket (or tickets). I can add it to this patch, too, but it's probably not the only function that's still in there but never gets used.
Fine with me either way, but don't forget to file it.
created a new ticket for this (#6674)
Applied to OMP; bug #6263 needs to be committed to OJS dev and stable, and ported to OCS dev and stable, before this can be committed there.