We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.

Bug 6579 - Can't move custom blocks
Can't move custom blocks
Product: OJS
Classification: Unclassified
Component: Plug-ins
All All
: P3 normal
Assigned To: PKP Support
Depends on:
  Show dependency treegraph
Reported: 2011-04-12 12:14 PDT by James MacGregor
Modified: 2011-04-15 15:49 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:

Patch against OJS pre-2.3.5 (887 bytes, patch)
2011-04-15 14:50 PDT, Alec Smecher
Details | Diff
Additional patch against OJS pre-2.3.5 (2.14 KB, patch)
2011-04-15 15:41 PDT, Alec Smecher
Details | Diff
Additional patch against OJS pre-2.3.5 (2.12 KB, patch)
2011-04-15 15:43 PDT, Alec Smecher
Details | Diff
Patch against OCS 2.3.3-1 (1.89 KB, patch)
2011-04-15 15:48 PDT, Alec Smecher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James MacGregor 2011-04-12 12:14:22 PDT
I've started with a fresh copy of ojs-stable-2_3; freshly-installed OJS; newly-set up journal. I can enable the custom block plugin; create new custom blocks; fill them with information and have them display in the right navigation bar just fine. The *only* thing I still can't do is move them up/down OR right/left. 

Taking a look at the plugin_settings table, it looks like the table is missing rows for each custom block -- specifically, the row that sets the "seq" setting_value, which determines plugin order. (Otherwise, each custom block as three rows each -- context, enabled, and blockContent.) I can create the seq rows manually myself in the DB, and set the vertical sort order for the custom block that way, but even after that the vertical sorting seems wonky, and I still can't move the custom block horizontally. 

This may be related to Bug 6413, which has been filed against OCS, but the patch filed there already appears to be present in my OJS checkout.
Comment 1 Alec Smecher 2011-04-15 13:41:09 PDT
James, I can't duplicate this behavior. Could you send me a DB dump from your install?
Comment 2 Alec Smecher 2011-04-15 14:50:37 PDT
Created attachment 3490 [details]
Patch against OJS pre-2.3.5

James, I'm not sure why, but versions.current is marked 0 for your customBlockManager. This might've caused that to happen if you tried to upload a new version of the plugin via the plugin installer, but I don't know why that would be the case with a new install. Could you try a new install and see if you can still duplicate that behavior?
Comment 3 Alec Smecher 2011-04-15 15:41:15 PDT
Created attachment 3491 [details]
Additional patch against OJS pre-2.3.5

Correct escaping of plugin names e.g. that include spaces.
Comment 4 Alec Smecher 2011-04-15 15:43:07 PDT
Created attachment 3492 [details]
Additional patch against OJS pre-2.3.5

(Fixed forgotten echo statement)
Comment 5 Alec Smecher 2011-04-15 15:48:54 PDT
Created attachment 3493 [details]
Patch against OCS 2.3.3-1