PKP Bugzilla – Bug 6543
Files sent to copyediting don't show date sent
Last modified: 2011-03-25 14:26:34 PDT
We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.
The file Ids from the review stage and the editing stage aren't matching up, causing the date sent to be hidden.
Alec, is there any use for the source file id in article files anymore? It doesn't seem to be used anywhere functionally.
When a file goes from one part of the workflow to another, it gets a new file ID and starts counting again from an initial revision; the source_file_id and source_revision point back to the previous stage where the file came from. The conditional you changed was trying to determine whether or not the file in copyediting came from a particular file in the review stage -- I don't think the fix is correct. Are the source_file_id and source_revision not getting set?
Got it--The new file is being set in the signoff correctly in SectionEditorAction::setCopyeditFile(), but is being set again (to the original file) right after that method is called in SubmissionEditHandler::editorReview().
Alec, if this is okay shall i put it in stable?
Yes, if you've tested it.
Created attachment 3474 [details]
Patch against OJS pre-2.3.5
Pushed to official.