PKP Bugzilla – Bug 5642
Article View enhancements
Last modified: 2010-09-23 17:11:53 PDT
We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.
I think we could make a few minor tweaks to the article view template to better display the non-sidebar reading tools, specifically the AddThis button; the "Add Comment" link; and the "Download this PDF File" link. If enabled/available, they are currently haphazardly grouped at the bottom of the HTML or PDF galley file; there's no consistent number of line breaks between links, and they can take up a fair amount of real estate.
1. There is already a "Post Comment" link in the sidebar, so I think the "Add Comment" link is redundant and can be removed.
2. The Download PDF link can probably stay, even though the "Print this article" button accomplishes the same thing. It's pretty content- and object-specific.
3. The AddThis button should probably be moved to the Article Tools / Reading Tools block.
I know this is sort of sneaking in before the final deadline, but I'd really like to see these changes made -- it'll just tighten up the new article UI that much more. Any comments? I can probably do this over the next day or two if it's ok.
*** Bug 4621 has been marked as a duplicate of this bug. ***
A note about #1 -- the "Add a comment" link was added to the main article pane recently to help encourage people to use the commenting feature. Previous to that, it was only on the reading tools sidebar and I suspect its lack of visibility was part of the reason that commenting was so rarely used.
Also, I've recently asked Alex to have a look at the new PDF article view, particularly with respect to adding accordion-style hide/show of the RT sidebar, but it might be good to see if he has any suggestions for the scattering of tools on the main div.
Accordion hide-show has been implemented -- it's functional, but not perfect:
- It's currently arranged along the main nav, but included in its own div. Would probably be better (especially when the left sidebar is enabled) to put this in its own column between the article view and the sidebar.
- There's no actual animating at present; I'm unable to use the jQuery toggle because it doesn't allow control over the direction of the animation, and all of the alternatives available to me using jQuery UI and animate() were sufficiently complex to break it.
Done, implementing full screen mode instead of hiding sidebars: http://github.com/pkp/ojs/commit/fe4cb75e9909f59ebbdf205906588995f3b11f4e
Additional changes after some testing from James:
-Cosmetic update to fullscreen mode (added a black 'lightbox' background)
-Fixed font size plugin in RT (script wasn't included in article header template)