PKP Bugzilla – Bug 5217
Comment comment_title too short; can lead to DB error
Last modified: 2010-03-16 07:34:48 PDT
We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.
Comment comment_title too short; can lead to DB error.
The patch seems incomplete and inconsistent.
I does not update the templates and code that handles article_comments.comment_title only the code and templates handling comments.title.
Created attachment 3050 [details]
Fixes inconsistency in the original patch.
Created attachment 3051 [details]
Full fix for 2.2.4
A complete fix for bz5217 in the 2.2.x branch.
Tom, the "comments" and "article_comments" tables are related to different features; I'll fix them in separate Bugzilla entries (see bug #5199).
I know they're different features and I was not aware of bz#5199 but it is the exact problem I attempted to report in the forum (http://pkp.sfu.ca/support/forum/viewtopic.php?f=8&t=5877).
But unless I'm completely misreading your patch (which is certainly possible) you seem to update the column for one feature (article_comments.comment_title) but fixed the templates and code for a different one (comments.title) hence my confusion.