PKP Bugzilla – Full Text Bug Listing
|Summary:||Remove either the review type or have a single review workflow step.|
|Component:||General||Assignee:||Juan Pablo Alperin <juan>|
|Version Reported In:||Also Affects:|
|Bug Depends on:|
Description jerico 2010-11-24 07:47:30 PST
We currently have both, two workflow step constants for the review process and the review type field in the monograph. This is redundant information, creates code duplication and an unnecessary potential for inconsistent data and error. We should either remove the distinction between the two WORKFLOW_STAGE_* variables or remove the review type field then.
Comment 1 jerico 2011-02-22 12:52:08 PST
Current bugs caused by this inconsistency: - workflow stage policies have WORKFLOW_STAGE_ID_REVIEW_INTERNAL hard coded - a unique mapping from file stages to workflow stages is not possible (e.g. required for authorization of files) which means that file access can not be correctly authorized
Comment 2 jerico 2011-03-01 14:57:53 PST
Make sure that stage assignments in setup and default signoffs (stage participants) are compatible with the chosen solution.
Comment 3 jerico 2011-03-01 14:59:47 PST
Consider removing review type completely and count review rounds from 1 to n across both internal and external review and retrieve the review type passing by file -> submission -> workflow stage and leave the two different workflow stages in there.
Comment 4 Juan Pablo Alperin 2011-07-11 14:31:06 PDT
added some fixmes where the internal review is hardcoded: https://github.com/pkp/omp/commit/081fef9697114acbff07a5b2b31d7312daa42c4f Main implementations: https://github.com/pkp/omp/commit/f3e7eea7f5cb49967d38e00d03a4edd313232cfe https://github.com/pkp/pkp-lib/commit/4a89d3c9bf2899c37f1bae90ae5e31afc2ac153c File related grids: https://github.com/pkp/omp/commit/323329a834a9ad7e3002f5c4aa97c874eeac8a1e Timeline: https://github.com/pkp/omp/commit/3e1c03cfaf3c196b02192acdf110b25885d595af NewReviewRound form: https://github.com/pkp/omp/commit/ad42084a5b0f213cad64f1e6901c49ecfd7e67df Workflow Handler: https://github.com/pkp/omp/commit/9ea047080e3f5efae7fbbb5fac029f62c0a244b2
Comment 5 Juan Pablo Alperin 2011-07-22 15:40:02 PDT
files grid fallback on request var for stageId and data providers always get stageId from containing grid. https://github.com/pkp/omp/commit/b1bcac109dbf7f24bef67306c4740440fe6eb3d0
Comment 6 Alec Smecher 2011-12-13 12:05:02 PST