We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.

Bug 3503 - Notify registrant of payment being received
Notify registrant of payment being received
Status: RESOLVED FIXED
Product: OCS
Classification: Unclassified
Component: General
2.1.2
PC Windows NT
: P1 normal
Assigned To: PKP Support
http://pkp.sfu.ca/ocs2/cvs2/index.php...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-16 11:00 PDT by Kevin Stranack
Modified: 2009-02-23 18:48 PST (History)
2 users (show)

See Also:
Version Reported In:
Also Affects:


Attachments
Patch against OCS pre-2.3 CVS (12.19 KB, patch)
2009-02-10 18:28 PST, Matthew Crider
Details | Diff
Patch against OCS pre-2.1.2 CVS (12.20 KB, patch)
2009-02-10 18:29 PST, Matthew Crider
Details | Diff
Patch against OCS pre-2.3 CVS (15.99 KB, patch)
2009-02-12 14:06 PST, Matthew Crider
Details | Diff
Patch against OCS pre-2.1.2 CVS (15.78 KB, patch)
2009-02-12 14:06 PST, Matthew Crider
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Stranack 2008-05-16 11:00:16 PDT
When the CM marks a manual payment as received, an email (based on a template) should be automatically sent to the registrant.
Comment 1 Alec Smecher 2008-05-21 16:30:06 PDT
Deferring -- too many translations are already complete to introduce a new email template.
Comment 2 Matthew Crider 2009-02-10 18:28:54 PST
Created attachment 1419 [details]
Patch against OCS pre-2.3 CVS
Comment 3 Matthew Crider 2009-02-10 18:29:18 PST
Created attachment 1420 [details]
Patch against OCS pre-2.1.2 CVS
Comment 4 Alec Smecher 2009-02-11 11:31:48 PST
Matt, this appears to send out the notification email immediately upon the registration being recorded, rather than waiting for the payment to actually be completed. In the case of PayPal, this should happen a) when the PayPal IPN comes through or b) when the Manager marks the registration as paid; in the case of the manual payment plugin, it should happen when the Manager marks the registration as paid.

Also, when adding a new email to the system, make sure to include the relevant insert statements it in the upgrade scripts. (We're not totally consistent on this, but it's a good habit.) You can trim out the relevant excerpts after converting the email XML files to SQL using tools/dbXMLtoSQL.php.
Comment 5 Matthew Crider 2009-02-11 11:41:25 PST
Alec, the email should only be sent if the CM selects a checkbox underneath the 'Payment received' checkbox.  I didn't think it was a good idea for the system to send an email without the CM knowing about it, so I allow them to manually do it by selecting the checkbox.  Also, I thought this was just for manual payments like the OP stated, should I also implement for received paypal payents?

Didn't know about needing to modify the upgrade script--I'll keep that in mind from now on.
Comment 6 Alec Smecher 2009-02-11 11:51:52 PST
My mistake -- I thought this was on the attendee's registration form itself (!) not the Manager's "edit registration". Yes, this feature should be added to the PayPal plugin as well.
Comment 7 Matthew Crider 2009-02-12 14:06:26 PST
Created attachment 1438 [details]
Patch against OCS pre-2.3 CVS
Comment 8 Matthew Crider 2009-02-12 14:06:51 PST
Created attachment 1439 [details]
Patch against OCS pre-2.1.2 CVS
Comment 9 Alec Smecher 2009-02-23 18:07:39 PST
Looks good to me!
Comment 10 Matthew Crider 2009-02-23 18:48:31 PST
Committed to OCS stable and devel.  Closing.