Migration issues - Revision history

Jerico.dev: Added Alec to review round topic as he already seems to have done parts of the migration.

2011-03-01T05:05:17Z

Added Alec to review round topic as he already seems to have done parts of the migration.

Jerico.dev: Moved 6410 from DAOs to file management.

2011-03-01T05:03:53Z

Moved 6410 from DAOs to file management.

Jerico.dev: Described differences in OMP/OxS file handling in more detail.

2011-03-01T05:01:55Z

Described differences in OMP/OxS file handling in more detail.

Jerico.dev: Added CSS and bug 6410

2011-03-01T04:07:21Z

Added CSS and bug 6410

Jerico.dev: Added additional original bug to DAO clean-up topic

2011-02-16T14:43:06Z

Added additional original bug to DAO clean-up topic

Jerico.dev: Added JavaScript framework and DAO refactoring

2011-02-14T17:25:57Z

Added JavaScript framework and DAO refactoring

Jerico.dev: Added file management changes.

2010-11-19T01:17:21Z

Added file management changes.

Jerico.dev: Added review concept.

2010-11-02T22:23:36Z

Added review concept.

Jerico.dev: Reformulating workflow migration issue with new OMP authorization concept in mind.

2010-11-02T22:17:42Z

Reformulating workflow migration issue with new OMP authorization concept in mind.

24.82.135.132 at 16:31, 7 September 2010

2010-09-07T16:31:05Z

@@ Line 103: / Line 103: @@
 * migration effort: tbd.
-== Introduction of a new review concept (Matt, Juan) ==
+== Introduction of a new review concept (Matt, Juan, Alec) ==
 * description: OMP works with a "review round" concept (see ReviewRound class) that's not used in OJS/OCS. Conceptually the review of OMP and OJS/OCS are not so different to justify such a difference in the long run, though. Also the review rounds need clean-up in both OMP and the other apps.
 * original bug report(s): tbd., [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6406 6406 (clean-up only)]

@@ Line 50: / Line 50: @@
 * migration effort: tbd.
-== Listbuilders (Matt) ==
+== Listbuilders (Florian, Matt, Michael) ==
 For form elements that involve simple manipulation of lists (like masthead user lists in all apps), the MVC structure of modifying this data can be compacted into a listbuilder handler located in controllers/listbuilder/.  There are three source data types of listbuilders that can be used, here are some examples:
@@ Line 118: / Line 118: @@
 ** File management is now completely done in grids.
 We have to identify all places where files are being managed in the other applications and introduce the file handling grids and data model there.
-* original bug report(s): 5620, 6125, 6127, 6128
+* original bug report(s): 5620, 6125, 6127, 6128, [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6410 6410]
 * sample patch: this change is too complex to provide a patch that can be cross-applied
 * migration effort: the effort depends on the number of places where files are being used. This is much higher in OCS/OJS than in OHS. I guess the effort is somewhere between three days and two weeks for each of OJS/OCS because the whole file class hierarchy needs to be replaced and file handling grids to be written and inserted. A lot of file handling code should be re-usable from OMP, though as the rewrite has been made with migration in mind.
@@ Line 130: / Line 130: @@
 == DAO clean-up (Florian) ==
 * description: We do not have a consistent or clean design for DAOs that map OO inheritance hierarchies to database entities. Clean design options have been [[Data Access Objects (DAO)|specified in the Wiki]] and a reference implementation (submission files) exists in OMP.
-* original bug report(s): [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6127 6127], [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6185 6185], [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6410 6410]
+* original bug report(s): [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6127 6127], [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6185 6185]
 * sample patch: see the change sets linked in the linked bug report
 * migration effort: I so far identified the following class hierarchies as candidates for a re-factoring:

@@ Line 110: / Line 110: @@
 == File management (Matt, Florian) ==
-* description: The file data model and file handling has been re-designed for OMP. File management is now completely done in grids and the file data model has been cleaned up. We have to identify all places where files are being managed in the other applications and introduce the file handling grids and data model there. The OMP file implementation has an additional notion of "file genre" that doesn't exist in OJS/OCS. This must be factored out before OMP code can be migrated to OJS/OCS.
+* description: The file data model and file handling has been re-designed for OMP:
 * original bug report(s): 5620, 6125, 6127, 6128
 * sample patch: this change is too complex to provide a patch that can be cross-applied

@@ Line 123: / Line 123: @@
 == DAO clean-up (Florian) ==
 * description: We do not have a consistent or clean design for DAOs that map OO inheritance hierarchies to database entities. Clean design options have been [[Data Access Objects (DAO)|specified in the Wiki]] and a reference implementation (submission files) exists in OMP.
-* original bug report(s): [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6127 6127], [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6185 6185]
+* original bug report(s): [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6127 6127], [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6185 6185], [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6410 6410]
 * sample patch: see the change sets linked in the linked bug report
 * migration effort: I so far identified the following class hierarchies as candidates for a re-factoring:
 ** submissions: this would be a huge re-factoring and we should probably go about it in small feasible steps, it would be great to have a target design developed and available, though, to direct our changes even when on a small scale
 ** submission files (including configuration files and galleys): see the re-factoring in OMP, this needs to be ported to other apps. I guess: 2-3 weeks full time for OJS and OCS, 2 days for OHS

@@ Line 123: / Line 123: @@
 == DAO clean-up (Florian) ==
 * description: We do not have a consistent or clean design for DAOs that map OO inheritance hierarchies to database entities. Clean design options have been [[Data Access Objects (DAO)|specified in the Wiki]] and a reference implementation (submission files) exists in OMP.
-* original bug report(s): [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6127 6127]
+* original bug report(s): [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6127 6127], [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6185 6185]
 * sample patch: see the change sets linked in the linked bug report
 * migration effort: I so far identified the following class hierarchies as candidates for a re-factoring:
 ** submissions: this would be a huge re-factoring and we should probably go about it in small feasible steps, it would be great to have a target design developed and available, though, to direct our changes even when on a small scale
 ** submission files (including configuration files and galleys): see the re-factoring in OMP, this needs to be ported to other apps. I guess: 2-3 weeks full time for OJS and OCS, 2 days for OHS

@@ Line 31: / Line 31: @@
 * The overall migration effort therefore should be roughly 15-20 hours.
-== Layout overhaul (Brent, Juan, Matt) ==
+== Layout overhaul (Bruno, Brent, Juan, Matt) ==
 Changes for OMP: [http://github.com/pkp/omp/commit/84a6f3447e773754f5c4317f703707e94eca7194]
@@ Line 80: / Line 80: @@
 * migration effort: tbd.
-== Porting (non-role-based) workflow pages to OJS/OCS (Juan) ==
+== Process-based (rather than role-based) workflow pages (Florian, Juan) ==
 * description: Rather than using role based URLs for the editorial workflow we now have a /workflow handler that introduces a process based view on editorial workflow. This logic needs to be ported to OJS/OCS for consistency.
@@ Line 87: / Line 87: @@
 * migration effort: tbd
-== Introduction of a dashboard for users (Juan, Florian) ==
+== Introduction of a dashboard for users (Juan, Matt, Florian) ==
 * description: We'll introduce a common entry point for users. Among other things this contains a submission list which will be common to all roles and change depending on the "acting-as" user group.
@@ Line 104: / Line 104: @@
 == Introduction of a new review concept (Matt, Juan) ==
-* description: OMP works with a "review round" concept (see ReviewRound class) that's not used in OJS/OCS. Conceptually the review of OMP and OJS/OCS are not so different to justify such a difference in the long run, though.
+* description: OMP works with a "review round" concept (see ReviewRound class) that's not used in OJS/OCS. Conceptually the review of OMP and OJS/OCS are not so different to justify such a difference in the long run, though. Also the review rounds need clean-up in both OMP and the other apps.
-* original bug report(s): tbd.
+* original bug report(s): tbd., [http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6406 6406 (clean-up only)]
 * sample patch: tbd.
 * migration effort: tbd.
@@ Line 114: / Line 114: @@
 * sample patch: this change is too complex to provide a patch that can be cross-applied
 * migration effort: the effort depends on the number of places where files are being used. This is much higher in OCS/OJS than in OHS. I guess the effort is somewhere between three days and two weeks for each of OJS/OCS because the whole file class hierarchy needs to be replaced and file handling grids to be written and inserted. A lot of file handling code should be re-usable from OMP, though as the rewrite has been made with migration in mind.

← Older revision		Revision as of 01:17, 19 November 2010
Line 108:		Line 108:
	* sample patch: tbd.		* sample patch: tbd.
	* migration effort: tbd.		* migration effort: tbd.
		+
		+	== File management (Matt, Florian) ==
		+	* description: The file data model and file handling has been re-designed for OMP. File management is now completely done in grids and the file data model has been cleaned up. We have to identify all places where files are being managed in the other applications and introduce the file handling grids and data model there. The OMP file implementation has an additional notion of "file genre" that doesn't exist in OJS/OCS. This must be factored out before OMP code can be migrated to OJS/OCS.
		+	* original bug report(s): 5620, 6125, 6127, 6128
		+	* sample patch: this change is too complex to provide a patch that can be cross-applied
		+	* migration effort: the effort depends on the number of places where files are being used. This is much higher in OCS/OJS than in OHS. I guess the effort is somewhere between three days and two weeks for each of OJS/OCS because the whole file class hierarchy needs to be replaced and file handling grids to be written and inserted. A lot of file handling code should be re-usable from OMP, though as the rewrite has been made with migration in mind.

@@ Line 95: / Line 95: @@
 == Converting edit assignments to stage assignments (Matt) ==
-See http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=5557
+* description: OMP uses stage assignments (through the Signoff table) to enable users to access submissions.  Each user can access pages and components that are registered against a particular stage, and which they have been given access to (via automatic assignment or by the editor assigning them from the stage assignment grid, which lives at the top of the submission details page):
-* OMP uses stage assignments (through the Signoff table) to enable users to access submissions.  Each user can access pages and components that are registered against a particular stage, and which they have been given access to (via automatic assignment or by the editor assigning them from the stage assignment grid, which lives at the top of the submission details page).
+** All uses of the edit assignments classes need be replaced.
-**Pages and components are authorized to be used in a stage by using the WorkflowStageAccessPolicy in their authorize function.  This function's 4th parameter takes one of the WORKFLOW_STAGE_ID constants.
+** The g/setEditAssignments functions in each role submission class (authorSubmission, editorSubmission) needs to be removed (TBD if shortcut functions to the stage assignments should be in there)
-*All uses of the edit assignments classes need be replaced
+** The getAssociatedUserIds() function needs to be reimplemented to work with user groups and stage assignments
-*The g/setEditAssignments functions in each role submission class (authorSubmission, editorSubmission) needs to be removed (TBD if shortcut functions to the stage assignments should be in there)
+* original bug report(s): http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=5557
-*The getAssociatedUserIds() function needs to be reimplemented to work with user groups and stage assignments
+* sample patch: tbd.

← Older revision		Revision as of 16:31, 7 September 2010
Line 93:		Line 93:
	* sample patch: This is a large change with an individual change set per application. Therefore a sample patch cannot be provided.		* sample patch: This is a large change with an individual change set per application. Therefore a sample patch cannot be provided.
	* migration effort: tbd.		* migration effort: tbd.
		+
		+	== Converting edit assignments to stage assignments (Matt) ==
		+	See http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=5557
		+	* OMP uses stage assignments (through the Signoff table) to enable users to access submissions. Each user can access pages and components that are registered against a particular stage, and which they have been given access to (via automatic assignment or by the editor assigning them from the stage assignment grid, which lives at the top of the submission details page).
		+	**Pages and components are authorized to be used in a stage by using the WorkflowStageAccessPolicy in their authorize function. This function's 4th parameter takes one of the WORKFLOW_STAGE_ID constants.
		+	*All uses of the edit assignments classes need be replaced
		+	*The g/setEditAssignments functions in each role submission class (authorSubmission, editorSubmission) needs to be removed (TBD if shortcut functions to the stage assignments should be in there)
		+	*The getAssociatedUserIds() function needs to be reimplemented to work with user groups and stage assignments