OJS v.2 - Copyediting - is this a bug?

[roberta_takenaka]

I am trying to understand the code in classes/submission/copyeditor/CopyeditorAction.inc.php at function uploadCopyeditVersion($copyeditorSubmission, $copyeditStage), where there are the lines:

Code: Select all

// Only allow an upload if they're in the initial or final copyediting
      // stages.
      if ($copyeditStage == 'initial' && ($copyeditorSubmission->getDateNotified() == null || $copyeditorSubmission->getDateCompleted() != null)) return;
      else if ($copyeditorSubmission->getDateFinalNotified() == null || $copyeditorSubmission->getDateFinalCompleted() != null) return;

Is anything missing in else if condition, like

$copyeditStage == 'final' &&

?

I think there is a bug here, because the copyeditor is allowed to upload a file, but the file can not be saved because the else if condition is true, so the return statement is executed.

[kevin]

Yes, that does seem to be a bug. Your suggested fix should work.

Thanks,

[nfeasey]

Did this issue get fixed in a subsequent release. We seem to be having the same issue in which everything seems to go ok with the upload but the file is not, in fact updated.

If this is the fix, how should it be coded??

Thanks in advance.

[asmecher]

Hello,

This issue is corrected in the current version, OJS 2.0.2-1. Please check that you're using the most up-to-date version.

Regards,
Alec Smecher
Open Journal Systems

[Guest]

Thanks for you reply.

Unfortunately our version is being customized for version 2.0.1 so I hesitate to upgrade at this point as it will affect an ongoing project.

Anyway you can give me the code in question as per this post so that I can just stick the fix in for now?

It would be really appreciated if possible.

Thanks in advance.

[Guest]

Hmm?

I thinking about it, I can just download the latest version and file the file in this post from the latest version and make the necessary changes.

I assume this is a safe thing to do.

[asmecher]

The above change in the snippet of code should be enough to correct the issue.

You might consider downloading a patch from 2.0.1 to 2.0.2-1 (see http://pkp.sfu.ca/ojs/download/patch/) and doing a dry run (e.g. patch --dry-run -p1 < the.patch.file). It's possible that you could still perform an upgrade with minimal conflicts.

Regards,
Alec Smecher
Open Journal Systems Team