OJS OCS OMP OHS

You are viewing the PKP Support Forum | PKP Home Wiki



Problem including peer reviews after patching to 2.4.2 to

Are you responsible for making OJS work -- installing, upgrading, migrating or troubleshooting? Do you think you've found a bug? Post in this forum.

Moderators: jmacgreg, btbell, michael, bdgregg, barbarah, asmecher

Forum rules
What to do if you have a technical problem with OJS:

1. Search the forum. You can do this from the Advanced Search Page or from our Google Custom Search, which will search the entire PKP site. If you are encountering an error, we especially recommend searching the forum for said error.

2. Check the FAQ to see if your question or error has already been resolved.

3. Post a question, but please, only after trying the above two solutions. If it's a workflow or usability question you should probably post to the OJS Editorial Support and Discussion subforum; if you have a development question, try the OJS Development subforum.

Problem including peer reviews after patching to 2.4.2 to

Postby szczuka » Tue Oct 15, 2013 5:35 am

Hi,

I have just upgraded (via patch) from OJS 2.3.6 to 2.4.2.
It did not happen without a glitch, but after manual modification of some files I finally managed to get it running. My site is quite significantly modified and these modifications keep create issues with patch.
One important problem that I have noticed and so far have no idea how to fix:
The "Import peer reviews" button in the notification e-mail window causes the whole window to go blank. The page "./index.php/FI/editor/emailEditorDecisionComment/send" is empty.
I suspect problems with html2text, but have no idea how to identify the source of the problem.

Another, minor but annoying problem - the page template in "User home" menu keeps changing randomly from my own (heavily modified) to systems default. This happens from time to time, I have not detected any pattern. I had similar problem with previous upgrade, but the previous solution (set "redirect to journal page" and clear caches) does not work.
I checked with several browsers, the problem is repeatable.

Best regards

Marcin Szczuka
szczuka
 
Posts: 14
Joined: Wed Aug 03, 2011 5:03 am

Re: Problem including peer reviews after patching to 2.4.2 t

Postby JasonNugent » Tue Oct 15, 2013 6:01 am

Hi Marcin,

Completely blank pages are usually the result of a PHP error. Can you look in your logs and see if anything is appearing there?

As for the user profile page, can you make sure that clearing the template cache is actually doing that? There may be permissions problems on the files themselves, and perhaps it isn't being deleted when you clear the cache.

Regards,
Jason
JasonNugent
Site Admin
 
Posts: 894
Joined: Tue Jan 10, 2006 6:20 am

Re: Problem including peer reviews after patching to 2.4.2 t

Postby szczuka » Tue Oct 15, 2013 7:39 am

Dear Jason,

Thanks for prompt reply.
After a quick consultation with our system administrators I managed to narrow the problem to events registered in Apache log, I quote them at the end.
It appears that there are calls to undefined variable/method getUserVar() and ArticleEventLogEntry::setArticleId() in file SectionEditorAction.inc.php
I have no idea what went wrong. As far as I can tell none of my actions during patch application (except for the patch itself) meddled with this particular file.

As a side note, the amount of logged Apache warnings after the update is worrisome. I did the update because I had to (needed PHP intl compatibility), but now I am starting to have second thoughts.

Cheers

Marcin Szczuka

[Tue Oct 15 14:31:00.156462 2013] [:error] [pid 667] [client 10.30.3.1:49894] NOTICE: Undefined variable: request (/home/misc/fundam/public_html/FI/classes/submission/sectionEditor/SectionEditorAction.inc.php:1984), referer: http://fi.mimuw.edu.pl/index.php/FI/edi ... ticleId=26
[Tue Oct 15 14:31:00.156527 2013] [:error] [pid 667] [client 10.30.3.1:49894] PHP Fatal error: Call to a member function getUserVar() on a non-object in /home/misc/fundam/public_html/FI/classes/submission/sectionEditor/SectionEditorAction.inc.php on line 1984, referer: http://fi.mimuw.edu.pl/index.php/FI/edi ... ticleId=26
[Tue Oct 15 14:31:38.006149 2013] [:error] [pid 8315] [client 10.30.3.1:49902] NOTICE: Undefined variable: request (/home/misc/fundam/public_html/FI/classes/submission/sectionEditor/SectionEditorAction.inc.php:1984), referer: http://fi.mimuw.edu.pl/index.php/FI/edi ... ticleId=26
[Tue Oct 15 14:31:38.006270 2013] [:error] [pid 8315] [client 10.30.3.1:49902] PHP Fatal error: Call to a member function getUserVar() on a non-object in /home/misc/fundam/public_html/FI/classes/submission/sectionEditor/SectionEditorAction.inc.php on line 1984, referer: http://fi.mimuw.edu.pl/index.php/FI/edi ... ticleId=26
[Tue Oct 15 14:38:54.288026 2013] [:error] [pid 12340] [client 10.30.3.1:49953] NOTICE: Undefined variable: request (/home/misc/fundam/public_html/FI/classes/submission/sectionEditor/SectionEditorAction.inc.php:1984), referer: http://fi.mimuw.edu.pl/index.php/FI/edi ... ticleId=26
[Tue Oct 15 14:38:54.288141 2013] [:error] [pid 12340] [client 10.30.3.1:49953] PHP Fatal error: Call to a member function getUserVar() on a non-object in /home/misc/fundam/public_html/FI/classes/submission/sectionEditor/SectionEditorAction.inc.php on line 1984, referer: http://fi.mimuw.edu.pl/index.php/FI/edi ... ticleId=26
[Tue Oct 15 15:07:55.191781 2013] [:error] [pid 22167] [client 2001:6a0:5001:2:51ff:2e15:e873:11bf:44140] PHP Fatal error: Call to undefined method ArticleEventLogEntry::setArticleId() in /home/misc/fundam/public_html/FI/classes/submission/sectionEditor/SectionEditorAction.inc.php on line 2347, referer: http://fi.mimuw.edu.pl/index.php/FI/sec ... Review/623
szczuka
 
Posts: 14
Joined: Wed Aug 03, 2011 5:03 am

Re: Problem including peer reviews after patching to 2.4.2 t

Postby szczuka » Tue Oct 15, 2013 8:51 am

Just an update.

I have managed to pinpoint the source of this problem.
For some reason the search pattern for patch program are different than in my original 2.3.6 files. So, patching has missed quite a few lines as the patch command cannot be easily set to disregard of empty spaces. I have replaced the SectionEditorAction.inc.php with the vanilla version taken from the 2.4.2 distribution and it seems to work. I hope this is the last major issue.
The minor issue - mixup with templates - is still there and extremely annoying.

Cheers,

Marcin Szczuka
szczuka
 
Posts: 14
Joined: Wed Aug 03, 2011 5:03 am

Re: Problem including peer reviews after patching to 2.4.2 t

Postby JasonNugent » Tue Oct 15, 2013 10:21 am

Hi Marcin,

Can you be certain that the patch tool didn't also miss parts of the user template area?

Regards,
Jason
JasonNugent
Site Admin
 
Posts: 894
Joined: Tue Jan 10, 2006 6:20 am

Re: Problem including peer reviews after patching to 2.4.2 t

Postby angelorocha » Tue May 06, 2014 6:37 pm

I have same problem, please, help me. This problem are solved? How do?
Thanks!

OJS version: 2.4.3
angelorocha
 
Posts: 3
Joined: Mon May 05, 2014 5:24 pm

Re: Problem including peer reviews after patching to 2.4.2 t

Postby asmecher » Tue May 06, 2014 7:01 pm

Hi angelorocha,

What problem do you mean? There are several described here.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 9076
Joined: Wed Aug 10, 2005 12:56 pm

Re: Problem including peer reviews after patching to 2.4.2 t

Postby angelorocha » Wed May 07, 2014 4:41 am

Hi!
The function "including peer reviews" not work, after clicking the button, the form is still empty, see print (Not incorporated because the images were too large):

http://xoopsfire.com/uploads/images/img ... 0538da.png

http://xoopsfire.com/uploads/images/img ... f1b584.png
angelorocha
 
Posts: 3
Joined: Mon May 05, 2014 5:24 pm

Re: Problem including peer reviews after patching to 2.4.2 t

Postby asmecher » Wed May 07, 2014 7:16 am

Hi angelorocha,

Is it possible that the reviewer entered text comments into the "For Editor Only" field -- or, in the case of a review form, that the form fields are designated as editor-only? If that's the case, this is expected behavior; no review content has been entered that is designated as intended for the reviewer.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 9076
Joined: Wed Aug 10, 2005 12:56 pm


Return to OJS Technical Support

Who is online

Users browsing this forum: Bing [Bot], Yahoo [Bot] and 9 guests