OJS OCS OMP OHS

You are viewing the PKP Support Forum | PKP Home Wiki



Notify Review link wrong? /reviewer/submissionReview/

Are you responsible for making OJS work -- installing, upgrading, migrating or troubleshooting? Do you think you've found a bug? Post in this forum.

Moderators: jmacgreg, btbell, michael, bdgregg, barbarah, asmecher

Forum rules
What to do if you have a technical problem with OJS:

1. Search the forum. You can do this from the Advanced Search Page or from our Google Custom Search, which will search the entire PKP site. If you are encountering an error, we especially recommend searching the forum for said error.

2. Check the FAQ to see if your question or error has already been resolved.

3. Post a question, but please, only after trying the above two solutions. If it's a workflow or usability question you should probably post to the OJS Editorial Support and Discussion subforum; if you have a development question, try the OJS Development subforum.

Notify Review link wrong? /reviewer/submissionReview/

Postby XavierMcHot » Mon Jun 17, 2013 6:07 am

Hi,

we have updated OJS to the latest version, and move the journal to a server with Litespeed and PHP5.
We have some problems.
One of that, is:
when a journal editor receive a new notification link on email, this link looks like
http://www.xxx.xx/index.php/xxx/reviewe ... peerReview

this link return a 404 Not Found .
If we manually modify the link to
http://www.xxx.xx/index.php/xxx/editor/ ... peerReview

there is no problem. I don't find a lot of information about it. I think the redirect must be automatically. No useful error log from the server.
Any help?

Thanks
XavierMcHot
 
Posts: 2
Joined: Mon Jun 17, 2013 5:57 am

Re: Notify Review link wrong? /reviewer/submissionReview/

Postby asmecher » Tue Jun 18, 2013 4:33 pm

Hi XavierMcHot,

I've tracked down the problematic line of code and filed a Bugzilla entry for it (see http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=8266). Feel free to CC yourself on the entry so that when its status changes you'll be notified.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 8860
Joined: Wed Aug 10, 2005 12:56 pm

Re: Notify Review link wrong? /reviewer/submissionReview/

Postby newbies » Sun Sep 15, 2013 6:03 pm

How can I get the diff file for bug 8266? I don't know which part of the code on this page should be used for patching https://github.com/pkp/ojs/commit/faa31 ... 30#diff-11
newbies
 
Posts: 84
Joined: Sat Feb 23, 2013 9:15 pm

Re: Notify Review link wrong? /reviewer/submissionReview/

Postby rauf » Wed Oct 09, 2013 11:34 am

We had the same problem here, there is a patch to solve it?
rauf
 
Posts: 9
Joined: Mon Jun 06, 2011 6:29 am

Re: Notify Review link wrong? /reviewer/submissionReview/

Postby raickonen » Wed Oct 09, 2013 12:31 pm

Hi Alec,

Same problem here, after upgrade from 2.3.5 to 2.4.2.

I found http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=8266 but status is WONT FIX.

And patch here:

https://github.com/pkp/ojs/commit/faa31d7fa99c27277483220e037b4f2fafc92f30


It's a big patch. Apply all or some part of it?

Luciano
raickonen
 
Posts: 34
Joined: Tue Nov 16, 2010 10:39 am

Re: Notify Review link wrong? /reviewer/submissionReview/

Postby JasonNugent » Wed Oct 09, 2013 1:49 pm

Hi everyone,

The problem stems from the fact that the notifications should not have been created at all. There was a bug in the old version that incorrectly created notifications for reviewers (not editors) so when users looked at their notification list, they saw notifications that should not have been there. The code that generates the URLs would incorrectly build them as part of the reviewer/ page structure.

The incorrect notifications just need to be deleted. I'll have a look and come back with an SQL statement that will resolve the problem.

Jason
JasonNugent
Site Admin
 
Posts: 888
Joined: Tue Jan 10, 2006 6:20 am

Re: Notify Review link wrong? /reviewer/submissionReview/

Postby JasonNugent » Thu Oct 10, 2013 6:29 am

Hi everyone,

I am attaching a file to this post that will correct the notifications. You should un-gzip it in your tools/ directory and run it as:

Code: Select all
php tools/fixNotifications.php


It will scan the notifications table and pull out those specific notifications associated with the NOTIFICATION_TYPE_REVIEWER_COMMENT and NOTIFICATION_TYPE_REVIEWER_FORM_COMMENT notification types. If the user associated with those notifications does not have either editor or section editor roles in that specific journal, it will remove the notification.

As usual, before running this tool please make a backup of your OJS database. I have tested it locally but obviously, your own installations may be different.

Regards,
Jason
Attachments
fixNotifications.php.gz
Command line tool to fix notifications.
(878 Bytes) Downloaded 24 times
JasonNugent
Site Admin
 
Posts: 888
Joined: Tue Jan 10, 2006 6:20 am

Re: Notify Review link wrong? /reviewer/submissionReview/

Postby rauf » Fri Oct 11, 2013 6:25 am

Thanks for your help. I'll try it.
rauf
 
Posts: 9
Joined: Mon Jun 06, 2011 6:29 am


Return to OJS Technical Support

Who is online

Users browsing this forum: Baidu [Spider] and 7 guests