OJS OCS OMP OHS

You are viewing the PKP Support Forum | PKP Home Wiki



searching Reviewer Interests returns 0 results

Are you responsible for making OJS work -- installing, upgrading, migrating or troubleshooting? Do you think you've found a bug? Post in this forum.

Moderators: jmacgreg, btbell, michael, bdgregg, barbarah, asmecher

Forum rules
What to do if you have a technical problem with OJS:

1. Search the forum. You can do this from the Advanced Search Page or from our Google Custom Search, which will search the entire PKP site. If you are encountering an error, we especially recommend searching the forum for said error.

2. Check the FAQ to see if your question or error has already been resolved.

3. Post a question, but please, only after trying the above two solutions. If it's a workflow or usability question you should probably post to the OJS Editorial Support and Discussion subforum; if you have a development question, try the OJS Development subforum.

searching Reviewer Interests returns 0 results

Postby agentsmith » Fri Oct 04, 2013 8:50 am

Hello,

We recently upgraded from 2.3.4 to 2.4.2 without error.

I notice now that when I do a search on reviewer interests from the journal manager role I get 0 results.

However when I do a search from the editor role to select a reviewer I do get proper results.

I took a look at the queries and notice the key difference. Doing a search from the editor/selectReviewer/xxxx page will use the user_interests table while from the journal manager role it will use the controlled_vocabs table.

SELECT DISTINCT u.* FROM users AS u LEFT JOIN controlled_vocabs cv ON (cv.assoc_type = 4096 AND cv.assoc_id = u.user_id AND cv.symbolic = 'interest') LEFT JOIN controlled_vocab_entries cve ON (cve.controlled_vocab_id = cv.controlled_vocab_id) LEFT JOIN controlled_vocab_entry_settings cves ON (cves.controlled_vocab_entry_id = cve.controlled_vocab_entry_id), roles AS r WHERE u.user_id = r.user_id AND r.journal_id = 17 AND LOWER(cves.setting_value) LIKE LOWER('%administration%')

the part of the query that says: cv.assoc_id = u.user_id will always make the query return 0 results as the cv.assoc_id field is always 0 for my install. Even when I add new users. The controlled_vocabs table is very small:

"controlled_vocab_id" "symbolic" "assoc_type" "assoc_id"
"104" "mods34-physicalDescription-form-marcform" "0" "0"
"103" "mods34-genre-marcgt" "0" "0"
"102" "mods34-typeOfResource" "0" "0"
"101" "mods34-name-role-roleTerms-marcrelator" "0" "0"
"100" "mods34-name-types" "0" "0"
"301" "openurl10-book-genres" "0" "0"
"300" "openurl10-journal-genres" "0" "0"
"200" "nlm30-publication-types" "0" "0"
"21426" "interest" "4096" "0"
"21427" "category" "0" "0"
"21428" "interest" "0" "0"

I imagine the data is wrong and not the code? Although I don't really understand the relationship between the cv.assoc_id and the u.user_id
when there is a user_interests table that would work.

Anyway,
In a related problem, the reviewing interests column on the page: /editor/selectReviewer/xxxx will always be blank even though the search will return the proper results.
On the profile page of a pre-upgrade existing user the reviewing interests does not display.
I can make the reviewing interest display by changing the controlled_vocab_entries.controlled_vocab_entry_id = 21428 all old entries are 21426
If I add a new reviewing interest for a user it will display however it removes the original interests. Note that the reviewing interest search for the journal manager still won't work for these people.
I imagine if the search problem is solved this secondary problem will also be solved.

I found a similiar problem mentioned here: http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=8271

Thanks
Jeremy
agentsmith
 
Posts: 36
Joined: Fri Sep 15, 2006 4:40 pm

Re: searching Reviewer Interests returns 0 results

Postby asmecher » Fri Oct 04, 2013 10:11 am

Hi Jeremy,

Thanks for reporting so clearly. I've filed this at http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=8439; watch there for a patch.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 8910
Joined: Wed Aug 10, 2005 12:56 pm

Re: searching Reviewer Interests returns 0 results

Postby asmecher » Fri Oct 04, 2013 10:41 am

Hi Jeremy,

I've filed a patch in the bug entry linked above; it should address the search issue though it may not address the display issue yet. Could you confirm?

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 8910
Joined: Wed Aug 10, 2005 12:56 pm

Re: searching Reviewer Interests returns 0 results

Postby agentsmith » Fri Oct 04, 2013 1:27 pm

Thanks.
The search is working.
Last edited by agentsmith on Fri Oct 04, 2013 1:32 pm, edited 1 time in total.
agentsmith
 
Posts: 36
Joined: Fri Sep 15, 2006 4:40 pm

Re: searching Reviewer Interests returns 0 results

Postby agentsmith » Fri Oct 04, 2013 2:12 pm

I noticed that the search does not work for "All Enrolled Users" but it does work for "Reviewers" and probably the other roles as well.

The query for All enrolled users is still

SELECT DISTINCT u.* FROM users AS u LEFT JOIN controlled_vocabs cv ON (cv.assoc_type = 4096 AND cv.assoc_id = u.user_id AND cv.symbolic = 'interest') LEFT JOIN controlled_vocab_entries cve ON (cve.controlled_vocab_id = cv.controlled_vocab_id) LEFT JOIN controlled_vocab_entry_settings cves ON (cves.controlled_vocab_entry_id = cve.controlled_vocab_entry_id), roles AS r WHERE u.user_id = r.user_id AND r.journal_id = 17 AND LOWER(cves.setting_value) LIKE LOWER('%administration%')
agentsmith
 
Posts: 36
Joined: Fri Sep 15, 2006 4:40 pm

Re: searching Reviewer Interests returns 0 results

Postby asmecher » Fri Oct 04, 2013 3:04 pm

Hi Jeremy,

Watch for an additional patch to pop up at the end of that bug entry.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 8910
Joined: Wed Aug 10, 2005 12:56 pm

Re: searching Reviewer Interests returns 0 results

Postby agentsmith » Mon Oct 07, 2013 8:20 am

Great!
Thanks that works.

Jeremy
agentsmith
 
Posts: 36
Joined: Fri Sep 15, 2006 4:40 pm


Return to OJS Technical Support

Who is online

Users browsing this forum: Bing [Bot] and 5 guests