We're a Canadian university library who will be utilizing OJS for journal hosting in the near future. Because of recent changes to legislation, those OJS instances will be required to conform to the WACG 2.0 standard. (To be clear: we always wanted to conform to the standard, but legislation has meant more resources are now available.) We also have an interest in creating a responsive theme for our mobile and tablet users.
To facilitate this, I've been working on a theme plugin, https://github.com/CUDevMaxwell/OJS-Modern-Theme. However, there are parts of OJS that would be hard to edit using a theme plugin, block code especially.
Take a quick look at this:
- Code: Select all
{$rightSidebarCode|regex_replace:'/<\/div>.*?<div/s':'</div><li class="divider"></li><div'|replace:'<br />':''|replace:'<div':'<li'|replace:'div>':'li>'|replace:'ul':'ul class="nav nav-list"'|replace:'span':'li'|replace:'li class="blockTitle"':'li class="nav-header"'|replace:'blockSubtitle':'nav-header sub-header'|replace:'<form':'<li><form'|replace:'/form>':'/form></li>'
This is... messy. And error prone.
So, my question: would it be best to fork the OJS repo on github, and edit the 'core' code? Or should we continue to develop the theme as a plugin? If the changes are of a high-enough quality, would the PKP developers want to pull our changes into the main project?
Thank you everyone!
