OJS OCS OMP OHS

You are viewing the PKP Support Forum | PKP Home Wiki



Multiple ID's on single page.

Are you responsible for making OJS work -- installing, upgrading, migrating or troubleshooting? Do you think you've found a bug? Post in this forum.

Moderators: jmacgreg, btbell, michael, bdgregg, barbarah, asmecher

Forum rules
What to do if you have a technical problem with OJS:

1. Search the forum. You can do this from the Advanced Search Page or from our Google Custom Search, which will search the entire PKP site. If you are encountering an error, we especially recommend searching the forum for said error.

2. Check the FAQ to see if your question or error has already been resolved.

3. Post a question, but please, only after trying the above two solutions. If it's a workflow or usability question you should probably post to the OJS Editorial Support and Discussion subforum; if you have a development question, try the OJS Development subforum.

Multiple ID's on single page.

Postby szmigieldesign » Wed Dec 12, 2012 1:15 pm

Hello,

It has recently come to my attention that OJS generates multiple elements with the same ID on Editorial Team pages. An example can be found here and here. In case of this pages, a div of id=member is being used multiple times. As far as I'm aware, each ID should be unique along the whole HTML document. Also, W3C validator reports many errors on Editorial Team pages (proof).

Is it only my OJS installation or is this a widespread error?
szmigieldesign
 
Posts: 30
Joined: Thu Aug 30, 2012 2:22 am
Location: PL

Re: Multiple ID's on single page.

Postby asmecher » Wed Dec 12, 2012 1:24 pm

Hi szmigieldesign,

The duplicate IDs have already been fixed (see https://github.com/pkp/ojs/commit/107420a3b06150a803026102c4e6f3f968b64441). We generally validate a scattering of pages during the testing process but don't do it comprehensively; you'll probably find a few validation issues here and there.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 8867
Joined: Wed Aug 10, 2005 12:56 pm

Re: Multiple ID's on single page.

Postby szmigieldesign » Wed Dec 12, 2012 1:29 pm

Ok, that's great news!
Are those changes already in OJS core? Should I update my OJS installation?
szmigieldesign
 
Posts: 30
Joined: Thu Aug 30, 2012 2:22 am
Location: PL

Re: Multiple ID's on single page.

Postby asmecher » Wed Dec 12, 2012 1:56 pm

Hi szmigieldesign,

Those changes aren't in any released version of OJS yet, but if you like, you can download patch equivalent for that commit from the github link. Those changes will be in all future releases of OJS.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 8867
Joined: Wed Aug 10, 2005 12:56 pm


Return to OJS Technical Support

Who is online

Users browsing this forum: imedpub and 3 guests