Review assignment not recorded in Event log in OJS 2.4.1

[aleskl]

Hi,
I just noticed another getId() error in our server log:

Code: Select all

PHP Fatal error:  Call to a member function getId() on a non-object in /var/www/html/ojs/classes/article/log/ArticleLog.inc.php on line 35, referer: http://www.ias-iss.org/ojs/IAS/reviewer/confirmReview?reviewId=179

and a similar error when the reviewer declined to review:

Code: Select all

PHP Fatal error:  Call to a member function getId() on a non-object in /var/www/html/ojs/classes/article/log/ArticleLog.inc.php on line 35, referer: http://www.ias-iss.org/ojs/IAS/reviewer/confirmReview?reviewId=189&declineReview=1

Apparently the Review assignment accepted or declined is no longer recorded in the submission's Event log. I assume that is because the reviewer was not logged in, because he/she followed the direct link from the review invitation email, so the line "$user =& $request->getUser();" in function logEvent() in \classes\article\log\ArticleLog.inc.php doesn't return anything and then "$user->getId()" in the next line fails. We have one-click reviewer access enabled.

The reviewer decision to accept or decline is correctly recorded in the Peer review section of the paper, it just doesn't get recorded in the Event log.

Cheers,
Ales

[JasonNugent]

Hi Ales,

Thanks for finding this. I've fixed it and if you like you can get a patch for the fix here: http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=8000

Cheers,
Jason