Some additional $request parameters missing

[aleskl]

I have noticed that some additional functions calls don't include the $request parameter, in addition to viewtopic.php?f=8&t=9118 and http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=7229.

In the error log, these lines appeared:

Code: Select all

ojs2 has produced an error\n  Message: WARNING: Missing argument 2 for SubmissionEditHandler::viewFile(), called in /var/www/html/ojs/pages/sectionEditor/SubmissionEditHandler.inc.php on line 1962 and defined\n  In file: /var/www/html/ojs/pages/sectionEditor/SubmissionEditHandler.inc.php\n  At line: 2239\n  Stacktrace: \n  Server info:\n   OS: Linux\n   PHP Version: 5.3.3\n   Apache Version: Apache/2.2.3 (CentOS)\n   DB Driver: mysql\n   DB server version: 5.0.95, referer: http://www.ias-iss.org/ojs/IAS/editor/proofGalley/934/833

Code: Select all

ojs2 has produced an error\n  Message: WARNING: Missing argument 2 for SubmissionLayoutHandler::viewFile(), called in /var/www/html/ojs/pages/layoutEditor/SubmissionLayoutHandler.inc.php on line 323 and defined\n  In file: /var/www/html/ojs/pages/layoutEditor/SubmissionLayoutHandler.inc.php\n  At line: 487\n  Stacktrace: \n  Server info:\n   OS: Linux\n   PHP Version: 5.3.3\n   Apache Version: Apache/2.2.3 (CentOS)\n   DB Driver: mysql\n   DB server version: 5.0.95, referer: http://www.ias-iss.org/ojs/IAS/layoutEditor/proofGalley/934/833

And here are some other errors found in our server error log:

Code: Select all

PHP Fatal error:  Call to a member function getJournal() on a non-object in /var/www/html/ojs/pages/author/AuthorHandler.inc.php on line 123

Code: Select all

PHP Fatal error:  Call to a member function getId() on a non-object in /var/www/html/ojs/classes/article/log/ArticleLog.inc.php on line 35, referer: http://www.ias-iss.org/ojs/IAS/reviewer/confirmReview?reviewId=175&declineReview=1

Code: Select all

PHP Fatal error:  Class 'Config' not found in /var/www/html/ojs/lib/pkp/classes/core/PKPApplication.inc.php on line 391, referer: http://www.ias-iss.org/ojs/IAS/article/view/787

I can't say from my side if anything is really wrong with the functioning of the system, but I'm afraid some users are experiencing errors (judging from above, section editors, reviewers and submitting authors). However, nobody has complained to me that something doesn't work, so perhaps the errors are just benign.

Regards, Ales

[JasonNugent]

Hi Ales,

No, these are definitely issues and the $request parameter does need to be included in the functions that get called in the Handler classes. We've been making an effort to reduce our dependency on static calls (i.e., Request::getJournal()) and use instead $request->getJournal(), but in order for the latter to work the $request object needs to be declared in the function argument list. I'll file a bug to reconcile some of this work and make the issues you've found here some of the first to get fixed.

Regards,
Jason

[JasonNugent]

Hi again, Ales,

Just regarding your last error about the Config class not being found in PKPApplication. Would it be possible to obtain a stack trace for that? You can turn those things on in the config file. That's an interesting one and a bit odd because the Config class is definitely loaded in the PKPApplication class. You've probably mentioned this in other posts, but could you also include your OJS version number and whether or not you're using any sort of APC cache, and if so, the version number for that?

Cheers,
Jason

[aleskl]

Hi Jason!

Regarding the 'Config' error - this one is actually rare and I can't replicate it myself, so I guess enabling stack-trace won't help. Looking at logs, it seems that it occurs randomly and not frequently, eg. the same IP has a lot of access entries, but only one or few generate this error. It seems that most of the errors were triggered by indexing bots. As I said, when I open the same page that generated the error, I get no errors. Strange, but probably nothing wrong regarding the functioning. I'll keep an eye on this and see if I can conclude anything more specific.

I'm using OJS 2.4.1 with few customizations, nothing major, but the one related to this error may be that I rerouted the PDF display so that it opens in a new tab/window, not in the article page - I'm mentioning this. because almost all of these errors are originating from /article/view/ pages.

Regards, Ales