OJS OCS OMP OHS

You are viewing the PKP Support Forum | PKP Home Wiki



Unable to review in track director

Are you responsible for making OCS work -- installing, upgrading, migrating or troubleshooting? Do you think you've found a bug? Post in this forum.

Moderators: jmacgreg, michael, John

Forum rules
What to do if you have a technical problem with OCS:

1. Search the forum. You can do this from the Advanced Search Page or from our Google Custom Search, which will search the entire PKP site. If you are encountering an error, we especially recommend searching the forum for said error.

2. Check the FAQ to see if your question or error has already been resolved. Please note that this FAQ is OJS-centric, but most issues are applicable to both platforms.

3. Post a question, but please, only after trying the above two solutions. If it's a workflow or usability question you should probably post to the OCS Conference Support and Discussion subforum; if you have a development question, try the OCS Development subforum.

Unable to review in track director

Postby waluyo » Wed Jul 18, 2012 6:52 am

OCS 2.3.4 problem:

This is the scenario:
- A track director assign a reviewer as reviewer A
- The assigned reviewer emails the track director saying unable to review (not using reviewer account)
- The track director wants to put the information unable to review in the system, following the info from Reviewer A
- Then the track director click "Unable to review"
- The result is review underway? The same result if the track director click able to review!

I think this is not correct, the result should be "Regrets".

Anyone try this?

Regards, Waluyo
waluyo
 
Posts: 63
Joined: Wed Mar 14, 2012 4:46 pm
Location: UTHM - Malaysia

Re: Unable to review in track director

Postby asmecher » Tue Jul 24, 2012 4:05 pm

Hi all,

See also the bug entry at http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=7714.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 9071
Joined: Wed Aug 10, 2005 12:56 pm

Re: Unable to review in track director

Postby waluyo » Thu Jul 26, 2012 4:03 am

I have tried the changes in my local installation (OCS 2.3.4) that fix bug 7714.

Once I click the Unable to Review I have an error page confirmReviewForReviewer,
then I click the back button in the browser I can see both UNDERWAY and Regrets. I suspect this should be Regrets only.

When I see
pages/trackDirector/SubmissionEditHandler.inc.php

my file (OCS 2.3.4) looks different with that found here
https://github.com/pkp/ocs/blob/master/ ... er.inc.php

Should I do any other modifications (previous bugs?) for
classes/submission/trackDirector/TrackDirectorAction.inc.php
locale/en_US/locale.xml
and
pages/trackDirector/SubmissionEditHandler.inc.php

before applying changes for bug 7714

regards,
waluyo
waluyo
 
Posts: 63
Joined: Wed Mar 14, 2012 4:46 pm
Location: UTHM - Malaysia

Re: Unable to review in track director

Postby asmecher » Fri Jul 27, 2012 8:52 am

Hi Waluyo,

If the patch applied cleanly, you shouldn't need any other changes from the more recent version of the file. The "Underway" date actually tracks the date the user confirmed their availability, so it does make sense to track declines in this field as well -- though perhaps the field should be renamed "Confirmed" or something similar.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 9071
Joined: Wed Aug 10, 2005 12:56 pm

Re: Unable to review in track director

Postby waluyo » Sat Aug 04, 2012 7:46 pm

I am in OCS 2.3.4
After applying the changes, the result is correct.

However there is one problem
I have to reload the page after clicking either WILL DO THE REVIEW or UNABLE TO DO THE REVIEW

In Firefox, it gives me a blank page before reload
in Chrome, a message appear asking to reload

I just need to reload the page.

what is the problem with this?

regards,
Waluyo
Attachments
Screenshot-error.png
Screenshot-error.png (25.47 KiB) Viewed 3036 times
waluyo
 
Posts: 63
Joined: Wed Mar 14, 2012 4:46 pm
Location: UTHM - Malaysia

Re: Unable to review in track director

Postby asmecher » Sat Aug 04, 2012 10:39 pm

Hi Waluyo,

A 500 error code should be accompanied by a more detailed error message in your server log.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 9071
Joined: Wed Aug 10, 2005 12:56 pm

Re: Unable to review in track director

Postby waluyo » Sun Aug 05, 2012 8:46 pm

The system log said:
Code: Select all
[Sun Aug 05 10:34:03 2012] [error] [client 127.0.0.1] PHP Fatal error:  Call to undefined method ReviewAssignment::getSubmissionId() in /var/www/ocs/classes/submission/trackDirector/TrackDirectorAction.inc.php on line 1689


the problem is this code (writing log message ?)
Code: Select all
$entry->setLogMessage($accept?'log.review.reviewAcceptedByProxy':'log.review.reviewDeclinedByProxy', array('reviewerName' => $reviewer->getFullName(), 'paperId' => $reviewAssignment->getSubmissionId(), 'stage' => $reviewAssignment->getRound(), 'userName' => $user->getFullName()));


If I just commented that code, it just works

regards,
Waluyo
waluyo
 
Posts: 63
Joined: Wed Mar 14, 2012 4:46 pm
Location: UTHM - Malaysia

Re: Unable to review in track director

Postby asmecher » Thu Aug 09, 2012 8:47 am

Hi Waluyo,

You can correct this by changing $reviewAssignment->getSubmissionId() to $reviewAssignment->getPaperId() in the quoted line.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 9071
Joined: Wed Aug 10, 2005 12:56 pm

Re: Unable to review in track director

Postby waluyo » Thu Aug 09, 2012 5:13 pm

It didn't work, in addition I still need to change
Code: Select all
$reviewAssignment->getRound()

to
Code: Select all
$reviewAssignment->getPaperId()


Thanks, Alec, at least the tool for Track Director is now correct.

Regards,
Waluyo
waluyo
 
Posts: 63
Joined: Wed Mar 14, 2012 4:46 pm
Location: UTHM - Malaysia

Re: Unable to review in track director

Postby asmecher » Fri Aug 10, 2012 10:16 am

Hi Waluyo,

Actually, it should be $reviewAssignment->getStage(), not $reviewAssignment->getPaperId(). (The patch is written for OCS pre-2.4.0 and there are some changes in the underlying code since 2.3.x.)

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 9071
Joined: Wed Aug 10, 2005 12:56 pm

Re: Unable to review in track director

Postby waluyo » Fri Aug 10, 2012 3:00 pm

thank you for your suggestion,
I changed to
Code: Select all
'stage' => $reviewAssignment->getStage()

it's ok.
The complete code for that line:
Code: Select all
$entry->setLogMessage($accept?'log.review.reviewAcceptedByProxy':'log.review.reviewDeclinedByProxy', array('reviewerName' => $reviewer->getFullName(), 'paperId' => $reviewAssignment->getPaperId(), 'stage' => $reviewAssignment->getStage(), 'userName' => $user->getFullName()));

regards,
waluyo
waluyo
 
Posts: 63
Joined: Wed Mar 14, 2012 4:46 pm
Location: UTHM - Malaysia


Return to OCS Technical Support

Who is online

Users browsing this forum: No registered users and 1 guest