Undefined variable templateMgr

[Banderson]

We recently discovered a server error on the third step of schedConfSetup in one of our OCS instances (running version 2.1.2-1). Cranking up error reporting, I got a message indicating that there was an undefined variable (@templateMgr) on line 62 of classes/manager/form/schedConfSetup/SchedConfSetupStep3Form.inc.php. This is in the display function:

function display() {
import('mail.MailTemplate');
$mail = &new MailTemplate('SUBMISSION_ACK');
if ($mail->isEnabled()) {
$templateMgr =& TemplateManager::getManager();
$templateMgr->assign('submissionAckEnabled', true);
}

if (Config::getVar('general', 'scheduled_tasks'))
$templateMgr->assign('scheduledTasksEnabled', true);

parent::display();
}

If I add:

$templateMgr =& TemplateManager::getManager();

... to the second "if" statement here, before the variable is assigned; but since I can't find a patch for this, I suspect there may be something else going on. Is there something we're not enabling in the interface? Is my kludge going to mess up other things?

Any help appreciated,

Bill Anderson
Georgia Tech Library

[JasonNugent]

Hi Bill,

That's a bug in the version of OCS you are using. It was fixed about three years ago in this commit:

https://github.com/pkp/ocs/commit/40d47 ... rm.inc.php

The problem is that the line:

Code: Select all

$templateMgr =& TemplateManager::getManager();


needs to be outside of the if() statement it is in. The problem with the way it is now is that it creates a variable in local scope. If you don't intend to upgrade, you can just move the line to just after the function display() { opening block.

Regards,
Jason

[Banderson]

Thanks, Jason -- pretty much what I figured. I just wanted to make sure there wasn't some reason for declaring the variable there.

Cheers,

Bill