Merge users has untranslated keys

[ramon]

Hello all,

When using the "Merge users" feature, the alert message displays the $oldUsername variable instead of the actual login selected first to merge.
It's a locale file issue, as this variable no longer exists. It is now $oldAccountCount, in the key manager.people.mergeUsers.confirm, at pkp/lib/locale/en_US/manager.xml

The Translation Plugin did not catch this difference when checking translations.

Here's the message with errors:

Code: Select all

Deseja realmente mesclar o cadastro do usuário "{$oldUsername}" com o cadastro do usuário "ramon"? O cadastro de "{$oldUsername}" será excluído permanentemente. Esta ação não é reversível!

However, $oldAccountCount brings a number, not the login...

[michael]

Hi Ramon,

Thanks for flagging this. Yes, you're correct, the locale key has changed and now includes the number of old accounts being merged into the new account (i.e. to support multi-account merge).

The full text should now read, e.g.:

Are you sure you wish to merge the selected 1 account(s) into the account with the username "test2"? The selected 1 accounts will not exist afterwards. This action is not reversible.

Not sure why this wasn't flagged as a changed key in the Translator Plugin -- we'll try and track it down.

Thanks,
Michael

[asmecher]

Hi all,

The patch linked at http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6907 should correct the parameter check; running it against pt_BR shows there are a few other cases with old parameters or parameter name typos.

Regards,
Alec Smecher
Public Knowledge Project Team

[ramon]

Hello all,

Thanks for the patch. We'll apply it as soon as possible and correct our local translations.
Is this patch OxS compatible? Meaning, can we apply it on what versions of OCS and/or OJS?

On another note, AFAIK, the "Merge users" feature only merges 1 account into the next one selected, so showing the number of previously selected user accounts seems unnecessary, while showing at least the previously selected login makes more sense, to prevent merging accounts by mistake.

[asmecher]

Hi Ramon,

This locale change coincides with a change to the Merge Users feature to allow multiple accounts to be merged simultaneously, so listing usernames is no longer practical.

The patch will also apply to recent releases of OCS and OHS.

Regards,
Alec Smecher
Public Knowledge Project Team