Bug report and fix on registration

[wuyh]

The original registration date will be changed once the manager try to make updates on the registration. For example, update a payment.
I found that this bug hidden in /classes/registration/form/registrationForm.inc.php, line 172.

Code: Select all

$registration->setDateRegistered(time());

everytime this form get executed, the registration time get changed. To fix this, i moved this line to line 163, the same file.

Code: Select all

      if (!isset($registration)) {
         $registration = &new Registration();
         $registration->setDateRegistered(time()); //bug fixed by WYH. set date only when it is a new registration
      }

version of OCS i have is 2.0.0.1.

[piotreba]

Hello, I am using 2.3.3.1 version of OCS and still there is a bug that when I update the payment time the registration date changes...



Peter

[jmacgreg]

Hi wuyh, Peter,

Wuyh, a belated thank-you for the fix. Peter, I have verified that this still hasn't been fixed in OCS 2.3.3-1. I've reported a bug here, and have modified wuyh's fix to work in 2.3.3-1 as well. Note that this is an untested patch, but I hope to have it verified and committed soon.

Cheers,
James