xmlimport joins section names

[arnost]

I have problem importing journal data with more than one section.

Here is beginning of my import XML file.

Code: Select all

<archive>
<issue>
<issue_description> ... deleted ...  </issue_description>
  <section>
     <section_name>articles</section_name>
   <section_order>1</section_order>
  </section>
  <section>
     <section_name>reviews</section_name>
   <section_order>2</section_order>
  </section>
<article>...

If I use xmlimport.php, I get folowing results:

Sections
• 1. articles
• 12. articlesreviews

Section name and section order for 'reviews' are joined together!

It should be:

Sections
• 1. articles
• 2. reviews

Is my import XML file broken? Or is it a bug in OJS?


I changed one line in xmlimport.php:
In function characterData, I changed line

Code: Select all

$_XML_DATA['section_data'][strtolower($matches[1])] .= $data;

to

Code: Select all

$_XML_DATA['section_data'][strtolower($matches[1])] = $data;

-> change ",= append" to "= set"

Now it display section names correctly. But it is maybe only stupid change which only hides problem

Arnost

[kevin]

Thanks, that is indeed a bug.

Here's a trivial patch that should fix it:

Code: Select all

Index: xmlimport.php
===================================================================
RCS file: /cvs/ojs/xmlimport.php,v
retrieving revision 1.7
diff -u -r1.7 xmlimport.php
--- xmlimport.php       13 May 2004 08:40:47 -0000      1.7
+++ xmlimport.php       10 Jun 2004 03:43:05 -0000
@@ -588,6 +588,7 @@
 
        } else if($_XML_DATA['current_tag'] == "^ARCHIVE^ISSUE^SECTION") {
                call_user_func($_XML_DATA['addSectionFunc'], $_XML_DATA['section_data']);
+               $_XML_DATA['section_data'] = array();
 
        } else if($_XML_DATA['current_tag'] == "^ARCHIVE^ISSUE^ARTICLE") {
                call_user_func($_XML_DATA['addArticleFunc'], $_XML_DATA['current_issue'], $_XML_DATA['issue_data']['year'], $_XML_DATA['article_data']);

[ramon]

Fellas,

We tried to use the system to publish previous issues, but when we try to change the year of the publication it does not insert them into the previous issues, it changes the future issues.

The only way to publish previous issues is the XML import???

thnks

[kevin]

Well, in your initial setup of the journal you could specify the "Initial Issue" to be the year of your first issue, and then publish back issues in order up to the present.

But neither this method nor the XML import is designed for publishing older issues _after_ you have already published current issues.