Year based subscription access

[rke4me]

Hi,
First, apology, if this is not the right place to post this issue.

When we provide a subscription based access to the reader for current year (e.g. Year 2009, Duration Jan. to Dec.), it seems that the reader can also access the previous years issues (e.g. Year 2008, 2007, 2006 ...) without any subscriptions.

Is there any possibilities in future OJS to give year-wise subscription as

1. Current Year Subscription ,

2. Previous Year Subscription

Thanks

-Rke

[michael]

Hi rke4me,

These are actually two separate things:
1) a valid subscription, which has a duration (e.g. 12 months), and
2) what a subscription provides access to

OJS has been designed in such a way that 2) enables subscription holders to access all subscription-restricted content. What you are asking for is to limit 2) to 1), the subscription duration. This is something that we could consider for future releases of OJS, but at this time there has not been much demand for this sort of limitation.

If you do require something of this sort in the short-term, you should be able to easily modify the subscription check functions (subscribedUser and subscribedDomain) in classes/issue/IssueAction.inc.php

Cheers,
Michael

[rke4me]

Dear Michael

Thanks for your reply and possible solution.

Hope that this may be included in the future OJS version.

Presently, I do not know how to modify the subscription check functions. It will be more helpful us you give a patch for this.

Thanks

-Rke

[michael]

Hi Rke and Jaik,

The subscribedUser function would need to be changed to something like the following (please note, this is not tested):

Code: Select all

    function subscribedUser(&$journal, $issueId = null, $articleId = null) {
        $user = &Request::getUser();
        $subscriptionDao = &DAORegistry::getDAO('SubscriptionDAO');
        $result = false;
        if (isset($user) && isset($journal)) {
            if (IssueAction::allowedPrePublicationAccess($journal)) {
                 $result = true;
            } else {
                if (isset($articleId)) {
                    $publishedArticleDao = &DAORegistry::getDAO('PublishedArticleDAO');
                    $publishedArticle = &$publishedArticleDao->getPublishedArticleByArticleId($articleId);
                    if (isset($publishedArticle)) {
                        import('subscription.SubscriptionDAO');
                        $result = $subscriptionDao->isValidSubscription(null, null, $user->getUserId(), $journal->getJournalId(), SUBSCRIPTION_DATE_BOTH, $publishedArticle->getDatePublished());
                    }
                } else if (isset($issueId)) {
                    $issueDao = &DAORegistry::getDAO('IssueDAO');
                    $issue = &$issueDao->getIssueById($issueId);
                    if (isset($issue) && $issue->getPublished()) {
                        import('subscription.SubscriptionDAO');
                        $result = $subscriptionDao->isValidSubscription(null, null, $user->getUserId(), $journal->getJournalId(), SUBSCRIPTION_DATE_BOTH, $issue->getDatePublished());
                    }
                }
            }
        }
        HookRegistry::call('IssueAction::subscribedUser', array(&$journal, &$result));
        return $result;
    }


Likewise, the subscibedDomain function would need to be changes along similar lines:

Code: Select all

    function subscribedDomain(&$journal, $issueId = null, $articleId = null) {
        $subscriptionDao = &DAORegistry::getDAO('SubscriptionDAO');
        $result = false;
        if (isset($journal)) {
            if (isset($articleId)) {
                $publishedArticleDao = &DAORegistry::getDAO('PublishedArticleDAO');
                $publishedArticle = &$publishedArticleDao->getPublishedArticleByArticleId($articleId);
                if (isset($publishedArticle)) {
                    import('subscription.SubscriptionDAO');
                    $result = $subscriptionDao->isValidSubscription(Request::getRemoteDomain(), Request::getRemoteAddr(), null, $journal->getJournalId(), SUBSCRIPTION_DATE_BOTH, $publishedArticle->getDatePublished());
                }
            } else if (isset($issueId)) {
                $issueDao = &DAORegistry::getDAO('IssueDAO');
                $issue = &$issueDao->getIssueById($issueId);
                if (isset($issue) && $issue->getPublished()) {
                    import('subscription.SubscriptionDAO');
                    $result = $subscriptionDao->isValidSubscription(Request::getRemoteDomain(), Request::getRemoteAddr(), null, $journal->getJournalId(), SUBSCRIPTION_DATE_BOTH, $issue->getDatePublished());
                }
            }
        }
        HookRegistry::call('IssueAction::subscribedDomain', array(&$journal, &$result));
        return $result;
    }


That is, in both cases we want to check whether the article or issue publication date falls within the subscription start and end dates.

Cheers,
Michael

[jaik_70]

Dear Micheel

Thanks for Php script for issue access.

The output of this given below:

Parse error: parse error, unexpected T_STRING in C:\ojs-2.2.3\classes\issue\IssueAction.inc.php on line 116

-Jaik

[michael]

Hi Jaik,

This error is typical if there is a missing brace '{' or '}' or missing semi-colon ';' at the end of the line. Please ensure that you are copy-and-pasting the code in its entirety and/or double-check that these are in place.

Cheers,
Michael

[jaik_70]

Dear Michael

You are right, there was a missing brace. Now we are getting following warning:

Warning: Missing argument 2 for IssueAction::allowedPrePublicationAccess(), called in C:\ojs-2.2.3\classes\issue\IssueAction.inc.php on line 120 and defined in C:\ojs-2.2.3\classes\issue\IssueAction.inc.php on line 80

Warning: Cannot modify header information - headers already sent by (output started at C:\ojs-2.2.3\classes\issue\IssueAction.inc.php:80) in C:\ojs-2.2.3\classes\template\TemplateManager.inc.php on line 240

Warning: Cannot modify header information - headers already sent by (output started at C:\ojs-2.2.3\classes\issue\IssueAction.inc.php:80) in C:\ojs-2.2.3\classes\template\TemplateManager.inc.php on line 243


-Jaik

[michael]

My bad. I had pulled that code from an old working directory (pre-2.2.3). Please try the following instead:

Code: Select all

    function subscribedUser(&$journal, $issueId = null, $articleId = null) {
        $user =& Request::getUser();
        $subscriptionDao =& DAORegistry::getDAO('SubscriptionDAO');
        $publishedArticleDao =& DAORegistry::getDAO('PublishedArticleDAO');
        $publishedArticle =& $publishedArticleDao->getPublishedArticleByArticleId($articleId);
        $result = false;
        if (isset($user) && isset($journal)) {
            if (IssueAction::allowedPrePublicationAccess($journal, $publishedArticle)) {
                 $result = true;
            } else {
                if (isset($articleId)) {
                    if (isset($publishedArticle)) {
                        import('subscription.SubscriptionDAO');
                        $result = $subscriptionDao->isValidSubscription(null, null, $user->getUserId(), $journal->getJournalId(), SUBSCRIPTION_DATE_BOTH, $publishedArticle->getDatePublished());
                    }
                } else if (isset($issueId)) {
                    $issueDao = &DAORegistry::getDAO('IssueDAO');
                    $issue = &$issueDao->getIssueById($issueId);
                    if (isset($issue) && $issue->getPublished()) {
                        import('subscription.SubscriptionDAO');
                        $result = $subscriptionDao->isValidSubscription(null, null, $user->getUserId(), $journal->getJournalId(), SUBSCRIPTION_DATE_BOTH, $issue->getDatePublished());
                    }
                }
            }
        }
        HookRegistry::call('IssueAction::subscribedUser', array(&$journal, &$result));
        return $result;
    }


Code: Select all

    function subscribedDomain(&$journal, $issueId = null, $articleId = null) {
        $subscriptionDao = &DAORegistry::getDAO('SubscriptionDAO');
        $result = false;
        if (isset($journal)) {
            if (isset($articleId)) {
                $publishedArticleDao = &DAORegistry::getDAO('PublishedArticleDAO');
                $publishedArticle = &$publishedArticleDao->getPublishedArticleByArticleId($articleId);
                if (isset($publishedArticle)) {
                    import('subscription.SubscriptionDAO');
                    $result = $subscriptionDao->isValidSubscription(Request::getRemoteDomain(), Request::getRemoteAddr(), null, $journal->getJournalId(), SUBSCRIPTION_DATE_BOTH, $publishedArticle->getDatePublished());
                }
            } else if (isset($issueId)) {
                $issueDao = &DAORegistry::getDAO('IssueDAO');
                $issue = &$issueDao->getIssueById($issueId);
                if (isset($issue) && $issue->getPublished()) {
                    import('subscription.SubscriptionDAO');
                    $result = $subscriptionDao->isValidSubscription(Request::getRemoteDomain(), Request::getRemoteAddr(), null, $journal->getJournalId(), SUBSCRIPTION_DATE_BOTH, $issue->getDatePublished());
                }
            }
        }
        HookRegistry::call('IssueAction::subscribedDomain', array(&$journal, &$result));
        return $result;
    }


[jaik_70]

Dear Michael

Thanks for providing this yaer based facilities. This will be more helpful to other OJS users if this nice script included in next version of OJS-2.3.

Also, I have few minor questions as:
1. Is this script work with OJS-2.2.2 too ?
2. Issue(s) can be govern through
Home > User > Journal Management > Subscriptions > Edit

with Start date* and End date*
Am I right ?

Thanks again

-Jaik

[michael]

Hi Jaik,

The above code was taken from OJS 2.2.3. It may work against OJS 2.2.2 with little or no modifications, but I would recommend testing it in either case.

Yes, you will need to set your issues as subscription-based and then grant subscriptions to individuals and institutions. There's detailed information about all of the options and settings in the OJS in an Hour guide, available here.

Cheers,
Michael

[jaik_70]

Dear Michael
Thanks for all suggestions.

-Jaik

[LPaul]

Hello

Should one expect this feature "Year based subscription access" in OJS 2.3 ?

Thanks

-LPaul

[jmacgreg]

Hi LPaul,

Yep! Anything that's in 2.2.3 will be in 2.3.

Cheers,
James

[michael]

Hi LPaul and James,

Just to clarify, the above code is not currently in either OJS 2.2.3 or OJS 2.3, but was simply provided as an example of how something like year-based subscription access could be achieved to overrride the current subscription check for an existing OJS instance.

Cheers,
Michael

[michael]

Hi Jaik,

Please find below some suggested code modifications that would be required for this to work in OJS 2.3.0.

Code: Select all

    function subscribedUser(&$journal, $issueId = null, $articleId = null) {
        $user =& Request::getUser();
        $subscriptionDao =& DAORegistry::getDAO('IndividualSubscriptionDAO');
        $publishedArticleDao =& DAORegistry::getDAO('PublishedArticleDAO');
        $publishedArticle =& $publishedArticleDao->getPublishedArticleByArticleId($articleId);
        $result = false;
        if (isset($user) && isset($journal)) {
            if (IssueAction::allowedPrePublicationAccess($journal, $publishedArticle)) {
                 $result = true;
            } else {
                if (isset($articleId)) {
                    if (isset($publishedArticle)) {
                        import('subscription.SubscriptionDAO');
                        $result = $subscriptionDao->isValidIndividualSubscription($user->getId(), $journal->getJournalId(), SUBSCRIPTION_DATE_BOTH, $publishedArticle->getDatePublished());
                    }
                } else if (isset($issueId)) {
                    $issueDao =& DAORegistry::getDAO('IssueDAO');
                    $issue =& $issueDao->getIssueById($issueId);
                    if (isset($issue) && $issue->getPublished()) {
                        import('subscription.SubscriptionDAO');
                        $result = $subscriptionDao->isValidIndividualSubscription($user->getId(), $journal->getJournalId(), SUBSCRIPTION_DATE_BOTH, $issue->getDatePublished());
                    }
                }
            }
        }
        HookRegistry::call('IssueAction::subscribedUser', array(&$journal, &$result));
        return $result;
    }


Code: Select all

    function subscribedDomain(&$journal, $issueId = null, $articleId = null) {
        $subscriptionDao =& DAORegistry::getDAO('InstitutionalSubscriptionDAO');
        $result = false;
        if (isset($journal)) {
            if (isset($articleId)) {
                $publishedArticleDao =& DAORegistry::getDAO('PublishedArticleDAO');
                $publishedArticle =& $publishedArticleDao->getPublishedArticleByArticleId($articleId);
                if (isset($publishedArticle)) {
                    import('subscription.SubscriptionDAO');
                    $result = $subscriptionDao->isValidInstitutionalSubscription(Request::getRemoteDomain(), Request::getRemoteAddr(), $journal->getJournalId(), SUBSCRIPTION_DATE_BOTH, $publishedArticle->getDatePublished());
                }
            } else if (isset($issueId)) {
                $issueDao =& DAORegistry::getDAO('IssueDAO');
                $issue =& $issueDao->getIssueById($issueId);
                if (isset($issue) && $issue->getPublished()) {
                    import('subscription.SubscriptionDAO');
                    $result = $subscriptionDao->isValidInstitutionalSubscription(Request::getRemoteDomain(), Request::getRemoteAddr(), $journal->getJournalId(), SUBSCRIPTION_DATE_BOTH, $issue->getDatePublished());
                }
            }
        }
        HookRegistry::call('IssueAction::subscribedDomain', array(&$journal, &$result));
        return $result;
    }


In effect, the required changes are almost identical to that required for OJS 2.2.x. The major difference is that in OJS 2.3 individual and institutional subscriptions have been separated in the database and code such that calls to the old isValidSubscription are now differentiated between isValidIndividualSubscription and isValidInstitutionalSubscription.

Cheers,
Michael