You are viewing the PKP Support Forum | PKP Home Wiki


OJS development discussion, enhancement requests, third-party patches and plug-ins.

Moderators: jmacgreg, btbell, michael, bdgregg, barbarah, asmecher

Forum rules
The Public Knowledge Project Support Forum is moving to http://forum.pkp.sfu.ca

This forum will be maintained permanently as an archived historical resource, but all new questions should be added to the new forum. Questions will no longer be monitored on this old forum after March 30, 2015.


Postby tingle » Sat Aug 20, 2011 7:53 pm

I'd like to use bcrypt with OJS


Here is a commit in a topic branch I created for bcrypt

https://github.com/tingletech/ojs/commi ... 33e0211841

I have not figured out how to get going with unit tests yet, but I don't see any other unit tests for OJS.

Any thoughts on this patch? I'd like to submit it. Should I send a pull request once I've done some more testing? Create a bugzilla ticket?
Posts: 4
Joined: Fri Aug 19, 2011 11:46 pm

Re: bcrypt

Postby tingle » Mon Aug 22, 2011 11:50 pm

I've updated my branch


the only change is in the subproject commit to pkp-lib


It seems like it works; but if someone uses it they will want to have the latest version of bcrypt; as the bcrypt PHP uses had a bug identified in June that affects some passwords that have the 8th bit set in a character.
Posts: 4
Joined: Fri Aug 19, 2011 11:46 pm

Re: bcrypt

Postby asmecher » Tue Aug 23, 2011 4:34 pm

Hi tingle,

I'll review your code on github in a sec. Once it's whipped into shape we can file a Bugzilla entry so that it gets merged in for a future release. Thanks for contributing!

Alec Smecher
Public Knowledge Project Team
Posts: 10015
Joined: Wed Aug 10, 2005 12:56 pm

Re: bcrypt

Postby tingle » Tue Aug 23, 2011 11:22 pm

Posts: 4
Joined: Fri Aug 19, 2011 11:46 pm

Return to OJS Development

Who is online

Users browsing this forum: No registered users and 1 guest