OJS OCS OMP OHS

You are viewing the PKP Support Forum | PKP Home Wiki



bcrypt

OJS development discussion, enhancement requests, third-party patches and plug-ins.

Moderators: jmacgreg, btbell, michael, bdgregg, barbarah, asmecher

Forum rules
Developer Resources:

Documentation: The OJS Technical Reference and the OJS API Reference are both available from the OJS Documentation page.

Git: You can access our public Git Repository here. Comprehensive Git usage instructions are available on the wiki.

Bugzilla: You can access our Bugzilla report tracker here.

Search: You can use our Google Custom Search to search across our main website, the support forum, and Bugzilla.

Questions and discussion are welcome, but if you have a workflow or usability question you should probably post to the OJS Editorial Support and Discussion subforum; if you have a technical support question, try the OJS Technical Support subforum.

bcrypt

Postby tingle » Sat Aug 20, 2011 7:53 pm

I'd like to use bcrypt with OJS

http://codahale.com/how-to-safely-store-a-password/

Here is a commit in a topic branch I created for bcrypt

https://github.com/tingletech/ojs/commi ... 33e0211841

I have not figured out how to get going with unit tests yet, but I don't see any other unit tests for OJS.

Any thoughts on this patch? I'd like to submit it. Should I send a pull request once I've done some more testing? Create a bugzilla ticket?
tingle
 
Posts: 4
Joined: Fri Aug 19, 2011 11:46 pm

Re: bcrypt

Postby tingle » Mon Aug 22, 2011 11:50 pm

I've updated my branch

https://github.com/tingletech/ojs/tree/bcrypt

the only change is in the subproject commit to pkp-lib

https://github.com/tingletech/pkp-lib/tree/bcrypt

It seems like it works; but if someone uses it they will want to have the latest version of bcrypt; as the bcrypt PHP uses had a bug identified in June that affects some passwords that have the 8th bit set in a character.
tingle
 
Posts: 4
Joined: Fri Aug 19, 2011 11:46 pm

Re: bcrypt

Postby asmecher » Tue Aug 23, 2011 4:34 pm

Hi tingle,

I'll review your code on github in a sec. Once it's whipped into shape we can file a Bugzilla entry so that it gets merged in for a future release. Thanks for contributing!

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 9201
Joined: Wed Aug 10, 2005 12:56 pm

Re: bcrypt

Postby tingle » Tue Aug 23, 2011 11:22 pm

tingle
 
Posts: 4
Joined: Fri Aug 19, 2011 11:46 pm


Return to OJS Development

Who is online

Users browsing this forum: jalperin, smanaer and 2 guests