asmecher wrote:I take it you expect bug #4364 can be fixed upstream? It seems to me that many of the fixes are suitable for upstream adoption, but unfortunately ADODB hasn't been especially responsive.
asmecher wrote:Everything looks fine to me except for #4363 -- I've never been particularly happy with that fix. I'll look into improving it first so that it doesn't generate so much garbage, then we can see about getting some of the code duplication under control.
asmecher wrote:I think regression testing for this is absolutely invaluable, particularly since many of the modified ADODB features are mostly used for upgrades and will therefore not be fully tested very thoroughly in the course of regular use.
asmecher wrote:we have a fledgling structure in place for JUnit testing
asmecher wrote:we'll have to reopen the issue for more consideration as we get closer to the release of OJS 2.3
asmecher wrote:one possible complication, though: we are occasionally making commits to the current "stable" (ojs2-branch-2_2_2) branch; if we created another branch from that for your Debian support work, we would need to ensure that those two branches were synced.
Users browsing this forum: Baidu [Spider] and 1 guest