OJS OCS OMP OHS

You are viewing the PKP Support Forum | PKP Home Wiki



Review assignment not recorded in Event log in OJS 2.4.1

Are you responsible for making OJS work -- installing, upgrading, migrating or troubleshooting? Do you think you've found a bug? Post in this forum.

Moderators: jmacgreg, btbell, michael, bdgregg, barbarah, asmecher

Forum rules
What to do if you have a technical problem with OJS:

1. Search the forum. You can do this from the Advanced Search Page or from our Google Custom Search, which will search the entire PKP site. If you are encountering an error, we especially recommend searching the forum for said error.

2. Check the FAQ to see if your question or error has already been resolved.

3. Post a question, but please, only after trying the above two solutions. If it's a workflow or usability question you should probably post to the OJS Editorial Support and Discussion subforum; if you have a development question, try the OJS Development subforum.

Review assignment not recorded in Event log in OJS 2.4.1

Postby aleskl » Fri Oct 26, 2012 5:01 am

Hi,
I just noticed another getId() error in our server log:
Code: Select all
PHP Fatal error:  Call to a member function getId() on a non-object in /var/www/html/ojs/classes/article/log/ArticleLog.inc.php on line 35, referer: http://www.ias-iss.org/ojs/IAS/reviewer/confirmReview?reviewId=179

and a similar error when the reviewer declined to review:
Code: Select all
PHP Fatal error:  Call to a member function getId() on a non-object in /var/www/html/ojs/classes/article/log/ArticleLog.inc.php on line 35, referer: http://www.ias-iss.org/ojs/IAS/reviewer/confirmReview?reviewId=189&declineReview=1

Apparently the Review assignment accepted or declined is no longer recorded in the submission's Event log. I assume that is because the reviewer was not logged in, because he/she followed the direct link from the review invitation email, so the line "$user =& $request->getUser();" in function logEvent() in \classes\article\log\ArticleLog.inc.php doesn't return anything and then "$user->getId()" in the next line fails. We have one-click reviewer access enabled.

The reviewer decision to accept or decline is correctly recorded in the Peer review section of the paper, it just doesn't get recorded in the Event log.

Cheers,
Ales
aleskl
 
Posts: 96
Joined: Mon Apr 11, 2011 7:08 am

Re: Review assignment not recorded in Event log in OJS 2.4.1

Postby JasonNugent » Sat Nov 03, 2012 12:08 pm

Hi Ales,

Thanks for finding this. I've fixed it and if you like you can get a patch for the fix here: http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=8000

Cheers,
Jason
JasonNugent
Site Admin
 
Posts: 849
Joined: Tue Jan 10, 2006 6:20 am


Return to OJS Technical Support

Who is online

Users browsing this forum: No registered users and 2 guests