OJS OCS OMP OHS

You are viewing the PKP Support Forum | PKP Home Wiki



Links to Help pages sometimes do not get generated

Are you responsible for making OJS work -- installing, upgrading, migrating or troubleshooting? Do you think you've found a bug? Post in this forum.

Moderators: jmacgreg, btbell, michael, bdgregg, barbarah, asmecher

Forum rules
What to do if you have a technical problem with OJS:

1. Search the forum. You can do this from the Advanced Search Page or from our Google Custom Search, which will search the entire PKP site. If you are encountering an error, we especially recommend searching the forum for said error.

2. Check the FAQ to see if your question or error has already been resolved.

3. Post a question, but please, only after trying the above two solutions. If it's a workflow or usability question you should probably post to the OJS Editorial Support and Discussion subforum; if you have a development question, try the OJS Development subforum.

Links to Help pages sometimes do not get generated

Postby aleskl » Thu Sep 27, 2012 5:31 am

Dear OJS support team!

I'm having some problems with displaying Help pages after clicking Journal Help in the right-hand column. On some location on the website, the link to the appropriate help page doesn't get generated: the link looks like this: javascript:openHelp('http://www.ias-iss.org/ojs/IAS/help'), but on other pages the link is like this one: javascript:openHelp('http://www.ias-iss.org/ojs/IAS/help/view/user/topic/000001').

The first link ends with a 500 server error page, the second link displays context sensitive help.

Looking at the server error log it looks like the view() function in HelpHandler.inc.php is being called without the second parameter, $request.
The errors returned are:
Code: Select all
[Thu Sep 27 13:38:58 2012] [error] [client 88.200.26.11] ojs2 has produced an error\n  Message: WARNING: Missing argument 2 for HelpHandler::view(), called in /var/www/html/ojs/lib/pkp/pages/help/HelpHandler.inc.php on line 39 and defined\n  In file: /var/www/html/ojs/lib/pkp/pages/help/HelpHandler.inc.php\n  At line: 58\n  Stacktrace: \n  Server info:\n   OS: Linux\n   PHP Version: 5.3.3\n   Apache Version: Apache/2.2.3 (CentOS)\n   DB Driver: mysql\n   DB server version: 5.0.95, referer: http://www.ias-iss.org/ojs/IAS/about/editorialPolicies
[Thu Sep 27 13:38:58 2012] [error] [client 88.200.26.11] NOTICE: Undefined variable: request (/var/www/html/ojs/lib/pkp/pages/help/HelpHandler.inc.php:63), referer: http://www.ias-iss.org/ojs/IAS/about/editorialPolicies
[Thu Sep 27 13:38:58 2012] [error] [client 88.200.26.11] PHP Fatal error:  Call to a member function getUserVar() on a non-object in /var/www/html/ojs/lib/pkp/pages/help/HelpHandler.inc.php on line 63, referer: http://www.ias-iss.org/ojs/IAS/about/editorialPolicies


I tried to see how the help function is called from problematic pages, but I couldn't find where the right column is generated, I have no idea what template I should look at. Two places, that generate errors after clicking on Journal help is the Article view page and some About pages (but not all).

I start noticing this after the upgrade of OJS to 2.4.0, but I'm not sure if the problem existed before - I just started to examine our server logs more closely now, after the upgrade, I ignored them before.

With kind regards,
Ales Kladnik
aleskl
 
Posts: 89
Joined: Mon Apr 11, 2011 7:08 am

Re: Links to Help pages sometimes do not get generated

Postby asmecher » Thu Sep 27, 2012 7:48 am

Hi Ales,

Thanks for reporting; I've fixed this and posted a patch at http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=7943.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 7717
Joined: Wed Aug 10, 2005 12:56 pm

Re: Links to Help pages sometimes do not get generated

Postby aleskl » Mon Oct 01, 2012 1:31 pm

Thank you Alec, your patch solves the problem with missing help pages. However, the Help link from the article view page calls the main help page, not context sensitive. I don't know if it exists for that page, but the link generated is still javascript:openHelp('http://www.ias-iss.org/ojs/IAS/help'), doesn't end in specific codes like this link from the journal homepage: javascript:openHelp('http://www.ias-iss.org/ojs/IAS/help/view/user/topic/000001').

Regards,
Ales
aleskl
 
Posts: 89
Joined: Mon Apr 11, 2011 7:08 am


Return to OJS Technical Support

Who is online

Users browsing this forum: No registered users and 1 guest