OJS OCS OMP OHS

You are viewing the PKP Support Forum | PKP Home Wiki



Leopard OS / Safari issue with display

Are you responsible for making OJS work -- installing, upgrading, migrating or troubleshooting? Do you think you've found a bug? Post in this forum.

Moderators: jmacgreg, btbell, michael, bdgregg, barbarah, asmecher

Forum rules
What to do if you have a technical problem with OJS:

1. Search the forum. You can do this from the Advanced Search Page or from our Google Custom Search, which will search the entire PKP site. If you are encountering an error, we especially recommend searching the forum for said error.

2. Check the FAQ to see if your question or error has already been resolved.

3. Post a question, but please, only after trying the above two solutions. If it's a workflow or usability question you should probably post to the OJS Editorial Support and Discussion subforum; if you have a development question, try the OJS Development subforum.

Leopard OS / Safari issue with display

Postby nrj » Fri Nov 09, 2007 2:26 pm

We've just discovered that the 'Comments' links on the Author/Archives/Editing page for an author who is proofing a mss, no longer display using Safari (the new Leopard one, 3.0.4). Very weird. The Proofing Instructions link is there, but the Comments link is not.
There may be other places but this is our first find.
Nancy
nrj
 
Posts: 20
Joined: Mon Feb 06, 2006 2:55 pm

Re: Leopard OS / Safari issue with display

Postby asmecher » Fri Nov 16, 2007 1:54 pm

Hi Nancy,

Unfortunately, I don't have a Leopard machine to test with; is there any chance you could investigate the problem further?

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 8597
Joined: Wed Aug 10, 2005 12:56 pm

Re: Leopard OS / Safari issue with display

Postby nrj » Fri Nov 16, 2007 2:16 pm

I'm trying to understand. And it turns put that it's a Safari problem even with Mac OS 10.4 that predates Leopard. It's something about the rendering of the html. I'll keep you posted.
Nancy
nrj
 
Posts: 20
Joined: Mon Feb 06, 2006 2:55 pm

Re: Leopard OS / Safari issue with display

Postby nrj » Fri Nov 16, 2007 2:28 pm

Alec,

This is a sample of the html that doesn't render in Safari. I think there's a mistake with the ';'

Proofreading Corrections
<a href="javascript:openComments('http://www.uic.edu/htbin/cgiwrap/bin/ojs/index.php/fm/editor/
viewProofreadComments/2023#47');"
class="icon"><img src="http://www.uic.edu/htbin/cgiwrap/bin/ojs/templates/images/icons/comment.gif" width="16" height="14"
border="0" alt="Comment" /></a>2007-11-10

&nbsp;&nbsp;
<a href="javascript:openHelp('http://www.uic.edu/htbin/cgiwrap/bin/ojs/index.php/fm/editor/instructions/proof')" class="action">Proofing Instructions</a>
nrj
 
Posts: 20
Joined: Mon Feb 06, 2006 2:55 pm

Re: Leopard OS / Safari issue with display

Postby asmecher » Fri Nov 16, 2007 3:00 pm

Hi Nancy,

Hmm, I think OTOH that the semicolon is OK, but you might be right -- could you try removing it from the template file to see if that corrects the problem? If you're looking at the Editor's "view proofreading comments" link, that appears in templates/sectionEditor/submission/proofread.tpl at approx. lines 176 and 178:
Code: Select all
        <a href="javascript:openComments('{url op="viewProofreadComments" path=$submission->getArticleId() anchor=$comment->getCommentId()}');" class="icon">{icon name="comment"}</a>{$comment->getDatePosted()|date_format:$dateFormatShort}
{else}
        <a href="javascript:openComments('{url op="viewProofreadComments" path=$submission->getArticleId()}');" class="icon">{icon name="comment"}</a>
...where the first line is used if a comment has already been posted, and the second if used otherwise.

You can test this hypothesis by removing the semicolons from the end of the {url ... } calls in each of these lines. (They are the only semicolons that appear in these code snippets.) Reload the page, and double-check that the semicolons are gone in your browser's View Source -- if they're not, you may need to double-check the permissions on your compiled templates in the templates/t_compile directory. If they're gone as expected, check to see if the link starts working. If it does, I can generate a patch for you to correct all of these cases in OJS 2.1.1 (and will also commit these changes to 2.2 CVS for release in the next version).

Thanks,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 8597
Joined: Wed Aug 10, 2005 12:56 pm

Re: Leopard OS / Safari issue with display

Postby mj » Fri Nov 16, 2007 8:56 pm

Hi guys,

I'm running both OSX 10.4 and 10.5, so give me a day or two to dig into this further and come up with a fix. Thanks for the helpful starting points.
mj
Site Admin
 
Posts: 304
Joined: Fri Mar 26, 2004 9:32 am
Location: Toronto, Canada

Re: Leopard OS / Safari issue with display

Postby mj » Sun Nov 18, 2007 4:17 pm

Hi,

I'm unable to reproduce this on either Safari 10.4 or 10.5, at least with the current OJS 2.2 CVS (see attached screenshots). It doesn't look like this file has changed between OJS 2.1.1 and 2.2, so presumably the same issue should occur in both versions. Nancy, can you post an image of what you're seeing?

safari.png
safari.png (23.25 KiB) Viewed 767 times

firefox.png
firefox.png (22.03 KiB) Viewed 768 times
mj
Site Admin
 
Posts: 304
Joined: Fri Mar 26, 2004 9:32 am
Location: Toronto, Canada

Re: Leopard OS / Safari issue with display

Postby nrj » Sun Nov 18, 2007 4:49 pm

Sure:

Picture 1.png
Picture 1.png (17.03 KiB) Viewed 788 times
nrj
 
Posts: 20
Joined: Mon Feb 06, 2006 2:55 pm

Re: Leopard OS / Safari issue with display

Postby nrj » Sun Nov 18, 2007 4:54 pm

That was Safari. Here's Firefox for the same article :

Picture 2.png
nrj
 
Posts: 20
Joined: Mon Feb 06, 2006 2:55 pm

Re: Leopard OS / Safari issue with display

Postby asmecher » Sun Nov 18, 2007 6:16 pm

Hi Nancy,

Could this be something as simple as a file permissions problem? If you enter the URL to that icon image directly, are you able to view it properly?

It might also be worth checking the server log for the access to that image file; you should see a server response code (e.g. 404) that might give some hints.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 8597
Joined: Wed Aug 10, 2005 12:56 pm

Re: Leopard OS / Safari issue with display

Postby mj » Sun Nov 18, 2007 6:44 pm

Alec, Nancy,

Nice catch, looking at the screenshot it does look like a webserver issue with the images. Hitting the URL http://www.uic.edu/htbin/cgiwrap/bin/ojs/templates/images/icons/comment.gif gives the error message:

CGIwrap Error: Script is not executable.
Issue chmod as appropriate /mnt/httpd/cgi-pub/ojs/templates/images/icons/comment.gif


It seems like this is related to the CGI wrapper that you're using on your server. I don't know whether that relates to permissions/ownership at the file system level, but it looks like it's affecting all images coming from within OJS directly (ie. prepended by the http://www.uic.edu/htbin/cgiwrap/bin/ojs/templates/images/ URL). To illustrate, the following image links work fine:

http://www.uic.edu/htbin/cgiwrap/bin/ojs/plugins/generic/webFeed/templates/images/atom10_logo.gif (atom feed logo image)
http://www.uic.edu/htbin/cgiwrap/bin/ojs/index.php/fm/article/viewFile/1956/1833/20151 (uploaded header image)

At the very least, however, broken images shouldn't destroy navigation; Alec, perhaps we should consider linking the date text ("2007-11-10") to the comments pop-up as well so it preserves the workflow?
mj
Site Admin
 
Posts: 304
Joined: Fri Mar 26, 2004 9:32 am
Location: Toronto, Canada

Re: Leopard OS / Safari issue with display

Postby asmecher » Mon Nov 19, 2007 10:55 am

Hi MJ & Nancy,

Actually, the {icon ...} Smarty tag should be generating alt tags for icon images; these alt strings should be used when the images aren't displayable for some reason. The alts are included properly in Nancy's quoted HTML snippets above, so I suppose the question is why Safari isn't displaying them...

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 8597
Joined: Wed Aug 10, 2005 12:56 pm


Return to OJS Technical Support

Who is online

Users browsing this forum: Google [Bot] and 2 guests