SEHL Bug 2.2-2.3: doesn't handle empty query terms parameter

[mgregson]

The Search Engine HighLighting plugin tries to highlight query terms in the page even when the query parameter in the referring URL is empty. This was observed because Google is not providing the query terms in the referer header when Google is accessed via SSL.

To reproduce:

1. Go to SSL Google, https://google.com
2. Query "new horizons site:fyhejournal.com"
3. Follow the link to the top result - the page layout is broken and if you inspect the source you will see <span class="sehl"></span> everywhere.

This affects 2.2 and 2.3.

I've attached a patch that resolves the issue.

Cheers
Mark

EDIT: I've noted a second issue, the output filter mangles the body tag and leaves it unclosed. I've updated the attached patch to correct this also.

[asmecher]

Hi Mark,

Thanks for contributing; I've filed this issue at http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=8018 and committed the changes.

Regards,
Alec Smecher
Public Knowledge Project Team

[mgregson]

No problem, thanks Alec!

Mark