setlocale bug

[anakin]

Hi, i'am a programmer from Türkiye, i find a bug on OHS.

In /var/www/lib/pkp/classes/i18n/PKPLocale.inc.php file there is a wrong setlocale parameter. On linux systems if you use

setlocale(LC_ALL, 'tr_TR'^) you will get fatal errors... because php can not find any class in this case. you must use

setlocale(LC_MESSAGES, 'tr_TR') instead. so i changed the code. This solves all translation problems in this forum... enjoy...

// on line 101
if (!@setlocale(LC_MESSAGES, $sysLocale, $locale)) {
// For PHP < 4.3.0
if(setlocale(LC_MESSAGES, $sysLocale) != $sysLocale) {
setlocale(LC_MESSAGES, $locale);
}
}

[anakin]

i modified the code like this (for windows and linux)

Code: Select all

if(strstr(PHP_OS, 'WIN')){
    if (!@setlocale(LC_ALL, $sysLocale, $locale)) {
        // For PHP < 4.3.0
        if(setlocale(LC_ALL, $sysLocale) != $sysLocale) {
            setlocale(LC_ALL, $locale);
        }
    }   
} else {
    if (!@setlocale(LC_MESSAGES, $sysLocale, $locale)) {
        // For PHP < 4.3.0
        if(setlocale(LC_MESSAGES, $sysLocale) != $sysLocale) {
            setlocale(LC_MESSAGES, $locale);
        }
    }
}

Important Note:
you must run this command on linux systems if the translation language not supported

Code: Select all

dpkg-reconfigure locales

and select your language code