OJS OCS OMP OHS

You are viewing the PKP Support Forum | PKP Home Wiki



Merge users has untranslated keys

Are you responsible for making OCS work -- installing, upgrading, migrating or troubleshooting? Do you think you've found a bug? Post in this forum.

Moderators: jmacgreg, michael, John

Forum rules
What to do if you have a technical problem with OCS:

1. Search the forum. You can do this from the Advanced Search Page or from our Google Custom Search, which will search the entire PKP site. If you are encountering an error, we especially recommend searching the forum for said error.

2. Check the FAQ to see if your question or error has already been resolved. Please note that this FAQ is OJS-centric, but most issues are applicable to both platforms.

3. Post a question, but please, only after trying the above two solutions. If it's a workflow or usability question you should probably post to the OCS Conference Support and Discussion subforum; if you have a development question, try the OCS Development subforum.

Merge users has untranslated keys

Postby ramon » Fri Sep 30, 2011 7:36 am

Hello all,

When using the "Merge users" feature, the alert message displays the $oldUsername variable instead of the actual login selected first to merge.
It's a locale file issue, as this variable no longer exists. It is now $oldAccountCount, in the key manager.people.mergeUsers.confirm, at pkp/lib/locale/en_US/manager.xml

The Translation Plugin did not catch this difference when checking translations.

Here's the message with errors:
Code: Select all
Deseja realmente mesclar o cadastro do usuário "{$oldUsername}" com o cadastro do usuário "ramon"? O cadastro de "{$oldUsername}" será excluído permanentemente. Esta ação não é reversível!


However, $oldAccountCount brings a number, not the login...
ramon
 
Posts: 931
Joined: Wed Oct 15, 2003 6:15 am
Location: Brasí­lia/DF - Brasil

Re: Merge users has untranslated keys

Postby michael » Tue Oct 04, 2011 1:56 pm

Hi Ramon,

Thanks for flagging this. Yes, you're correct, the locale key has changed and now includes the number of old accounts being merged into the new account (i.e. to support multi-account merge).

The full text should now read, e.g.:

Are you sure you wish to merge the selected 1 account(s) into the account with the username "test2"? The selected 1 accounts will not exist afterwards. This action is not reversible.

Not sure why this wasn't flagged as a changed key in the Translator Plugin -- we'll try and track it down.

Thanks,
Michael
michael
 
Posts: 405
Joined: Thu Mar 29, 2007 2:09 pm

Re: Merge users has untranslated keys

Postby asmecher » Tue Oct 04, 2011 3:44 pm

Hi all,

The patch linked at http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=6907 should correct the parameter check; running it against pt_BR shows there are a few other cases with old parameters or parameter name typos.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 8902
Joined: Wed Aug 10, 2005 12:56 pm

Re: Merge users has untranslated keys

Postby ramon » Wed Oct 05, 2011 7:22 am

Hello all,

Thanks for the patch. We'll apply it as soon as possible and correct our local translations.
Is this patch OxS compatible? Meaning, can we apply it on what versions of OCS and/or OJS?

On another note, AFAIK, the "Merge users" feature only merges 1 account into the next one selected, so showing the number of previously selected user accounts seems unnecessary, while showing at least the previously selected login makes more sense, to prevent merging accounts by mistake.
ramon
 
Posts: 931
Joined: Wed Oct 15, 2003 6:15 am
Location: Brasí­lia/DF - Brasil

Re: Merge users has untranslated keys

Postby asmecher » Wed Oct 05, 2011 8:50 am

Hi Ramon,

This locale change coincides with a change to the Merge Users feature to allow multiple accounts to be merged simultaneously, so listing usernames is no longer practical.

The patch will also apply to recent releases of OCS and OHS.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 8902
Joined: Wed Aug 10, 2005 12:56 pm


Return to OCS Technical Support

Who is online

Users browsing this forum: Yahoo [Bot] and 1 guest