Papers accepted then rejected accessible through search

[schiette]

A couple of abstracts that were accepted a while ago and are now "rejected" (declined) and archived because their author can no longer attend the conference will still show up using Search. Same thing if I put their status back to "in revision". If I delete the paper after archiving, then a Search involving these papers returns a blank page. I have to clear the data cache as an admin to get back to normal.

I'm using OCS 2.1.1-2; not possible to upgrade since I'm in the middle of a conference and changed templates quite a lot.

François

[jmacgreg]

Hi François,

I have somewhat replicated this, and have encountered some other slightly odd indexing issues. Please see http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=5503 for a bug report; please feel free to CC yourself to that report for updates.

Cheers,
James

[schiette]

The problem is probably that these accepted-then-archived papers remain listed in the "published_papers" table of the database. I'm hesitant to simply delete these entries directly into the database (any side effect?), so as a workaround, we must tell the SQL query to also check the status of the paper in the "papers" table:

In PaperSearchDAO.inc.php, add near the top an "import('paper.Paper');" which contains the definition of "SUBMISSION_STATUS_PUBLISHED".
Then add to the SQL query in function getPhraseResults the following:

"papers pp," in the FROM section
" pa.paper_id = pp.paper_id AND" in the WHERE section
"pp.status = ' . SUBMISSION_STATUS_PUBLISHED . ' AND" in the WHERE section.

Here is how the query looks like afterwards:

Code: Select all

      $result = &$this->retrieveCached(
         'SELECT
            o.paper_id,
            COUNT(*) AS count
         FROM
            published_papers pa,
            papers pp,
            sched_confs i,
            paper_search_objects o
         NATURAL JOIN ' . $sqlFrom . '
         WHERE
            pa.paper_id = o.paper_id AND
            pa.paper_id = pp.paper_id AND
            pp.status = ' . SUBMISSION_STATUS_PUBLISHED . ' AND
            i.sched_conf_id = pa.sched_conf_id AND ' .
            $sqlWhere . '
         GROUP BY o.paper_id
         ORDER BY count DESC
         LIMIT ' . $limit,
         $params,
         3600 * $cacheHours // Cache for 24 hours
      );


I don't know if it may prevent some results to show up or induce other side effects but I don't see any reason why a paper that has its status "PUBLISHED" in the table "papers" whould not be listed in the table "published_papers" anyway. The contrary appears to be the problem: a paper listed in "published_papers" may have its status entry not being set to "PUBLISHED" in the table "papers".

Anyway, use it at your own risks!

François

[asmecher]

Hi François,

Yes, that fix is correct -- I've posted an equivalent patch for the OCS 2.3.1 and 2.3.2 releases. Thanks for contributing!

Regards,
Alec Smecher
Public Knowledge Project Team