serious BUG in Submission Acknowledgment [RESOLVED]

[m.giordano]

Hi all,

we are experiencing a serious bug in proposal submission process.
If author doesn't input any keyword in step 2, the Submission Acknowledgment mail works fine.
Otherwise, when even one keyword is specified, the following errors occur:

the Submission Acknowledgment mail is sent but with a blank body and the keywords put in the subject in place of 'Submission Acknowledgment'
the keywords input by author are definitely lost in the submission record

Giving a first glance to the code it seems that in file templates\presenter\submit\step2.tpl, line 264, the name of the keyword text box goes in conflict with the subject property of the mail object somewhere.
We are studying the code to find a suitable workaround but we need help because we hardly understand the implications of any modification...

Thank you

Marco

PS: OCS 2.0.0-1 on a LAMP box

[m.gori]

Hello everyboy,

we found the way to workaround this problem.

As long as the conflict was with the "subject" form field at line 264, in templates\presenter\submit\step2.tpl, I then modified it in something else,
for example "metasubject". So we now have:
[...] <input type="text" class="textField" name="metasubject" id="metasubject" [...]
I guess the latter change is useless, but, well, you never know.....

After that, other modifications are to be made in classes\presenter\form\submit\PresenterSubmitStep2Form.inc.php, which is the code invoked "after" step 2 in the submission process:
- at line 104 'subject' becomes 'metasubject' (i.e. take the "metasubject" value from the form and paste it in the form object property, named "metasubject" as well);
- at line 171 the instruction becomes: $paper->setSubject($this->getData('metasubject')); (i.e. assign to the paper the "metasubject" property belonging to the fom object).

Maybe there are other (and more "structural") ways to solve this, but anyway everything seems to work fine now, both with keywords inserting and aknowledgment email contents

At your service for any other details on this issue.

Regards,
Marco

[asmecher]

Hi Marco,

This is bug #3072 (http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=3072); there's a patch there to correct it. This fix will be included with the next release, OCS 2.1.

Regards,
Alec Smecher
Public Knowledge Project Team

[m.gori]

Hello Alec sorry, we missed that patch ...

it was useful and interesting anyway to surf through the (powerful) system and handle with the code
Thanks again

Marco