OJS OCS OMP OHS

You are viewing the PKP Support Forum | PKP Home Wiki



Notification of submission - mixed signature

For discussion of ideas, functional requirements, interests regarding the Open Monograph Press.

Moderators: jmacgreg, John

Forum rules
Please feel free to post any questions or start any discussion about OMP here. We'll let you know via this forum when OMP is ready to download and test. You may also want to keep an eye on our OMP page.

Notification of submission - mixed signature

Postby jpowell » Mon Jun 30, 2014 9:05 am

Hello. One of our staff input the first submission into their new OMP site on behalf of the author. She did it by creating the author profile first and then making the submission. The signature in the notification of submission that resulted contained her name (she is principal contact) but then added the actual author's institutional affiliation instead of that of the principal contributor.
Thanks for your help,
Judy
jpowell
 
Posts: 81
Joined: Wed Feb 03, 2010 3:44 pm

Re: Notification of submission - mixed signature

Postby asmecher » Wed Jul 02, 2014 5:26 pm

Hi Judy,

I've filed this for attention at http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=8837 -- feel free to CC yourself on the entry so you'll be notified when its status changes.

Regards,
Alec Smecher
Public Knowledge Project Team
asmecher
 
Posts: 9050
Joined: Wed Aug 10, 2005 12:56 pm

Re: Notification of submission - mixed signature

Postby JasonNugent » Tue Aug 19, 2014 5:21 am

Hi Judy,

I have commented on the bug on the bug report. Can you try my suggestion to see if that solves your problem?

http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=8837

Cheers,
Jason
JasonNugent
Site Admin
 
Posts: 894
Joined: Tue Jan 10, 2006 6:20 am

Re: Notification of submission - mixed signature

Postby cedavid » Wed Oct 22, 2014 8:54 am

Jason,
The wording in the email is correct and we do not want to change it.
The issue we are experiencing is with the submission_ack email being sent to the author.
In the closing signature the correct contactName is showing correctly.
The Author's affiliation is showing up after the contactName information which should not be attached to the editorial contact information on this email.

We now have examples with this issue arising even when the author submits on their own without any intervention by the editorial contact.

Hope this helps clarify the issue.

Thanks,
Edward
cedavid
 
Posts: 30
Joined: Thu Jul 17, 2014 7:17 am
Location: Calgary, Alberta, Canada

Re: Notification of submission - mixed signature

Postby JasonNugent » Wed Oct 22, 2014 9:20 am

Hi Edward,

Thanks for the follow up. Let me describe whats happening so we can clear this up.

There are two mail templates used here. SUBMISSION_ACK and SUBMISSION_ACK_NOT_USER. The first goes to the user who is logged into OMP (the person actually clicking submit). The second goes to the authors.

In both cases, the signature on those messages is being built from the code:

Code: Select all
 $context->getSetting('contactName') . "\n" . $context->getLocalizedName()


So, you end up with something like:
Jason Nugent
Public Knowledge Project

or whatever those two values are set to in the Press settings page. They aren't being pulled from the author's affiliation. Can you check your press settings and see what those two values are? Maybe we need to file a bug to indicate that one of those templates needs to be changed to not include the localized press name.

Regards,
Jason
JasonNugent
Site Admin
 
Posts: 894
Joined: Tue Jan 10, 2006 6:20 am

Re: Notification of submission - mixed signature

Postby jpowell » Wed Oct 22, 2014 11:00 am

Hi Jason. In case it is helpful I have attached a screen shot of our press settings.

So, instead of a closing signature of
Peter Enman
University of Calgary Press

we are getting something like
Peter Enman
Contract Academic Staff, Dept. of English and Film Studies

Some more info - I just checked the author profiles of the examples we have and found that "Contract Academic Staff, Dept. of English and Film Studies" comes from what the author has in the Signature box of his profile. The only ones that are correct are ones where the author has not put anything in the signature box.

Hope that helps,
Judy
Attachments
Press settings_contact.jpg
Press settings_contact.jpg (72.99 KiB) Viewed 295 times
jpowell
 
Posts: 81
Joined: Wed Feb 03, 2010 3:44 pm

Re: Notification of submission - mixed signature

Postby JasonNugent » Thu Oct 23, 2014 11:26 am

Alright, nice. I was finally able to duplicate the bug and I believe it is fixed. I'll have a patch for your shortly if you'd like it sooner, but it will also be in the upcoming 1.1.1 release.

Regards,
Jason
JasonNugent
Site Admin
 
Posts: 894
Joined: Tue Jan 10, 2006 6:20 am

Re: Notification of submission - mixed signature

Postby JasonNugent » Thu Oct 23, 2014 12:07 pm

Two commits against OMP 1.1 to fix this now:

First, in the OMP top level directory:

https://github.com/pkp/omp/commit/f0c87 ... db382.diff

and then in the lib/pkp directory:

https://github.com/pkp/pkp-lib/commit/3 ... 4d530.diff

Cheers,
Jason
JasonNugent
Site Admin
 
Posts: 894
Joined: Tue Jan 10, 2006 6:20 am

Re: Notification of submission - mixed signature

Postby cedavid » Fri Oct 24, 2014 10:54 am

Applied the patches to OMP.

I had one of our people do a test and here is the response back.

I submitted a "Test Submission" through P.'s author account but no notification has come. This was also the case with a submission by an author named J. F. She stopped at step 3 so I logged in as her and finished it but no notification has come and it does not show on my dashboard. Gah!


Did I do something to mess this up.

Thanks,
Edward
cedavid
 
Posts: 30
Joined: Thu Jul 17, 2014 7:17 am
Location: Calgary, Alberta, Canada

Re: Notification of submission - mixed signature

Postby JasonNugent » Fri Oct 24, 2014 11:16 am

Hi Edward,

How did you apply the patches?

Cheers,
Jason
JasonNugent
Site Admin
 
Posts: 894
Joined: Tue Jan 10, 2006 6:20 am

Re: Notification of submission - mixed signature

Postby cedavid » Fri Oct 24, 2014 11:21 am

Deleted the lines that needed to be deleted and then copy and pasted the correct line in place.
Just went in and double checked and the code looks correct.

Did not know how to apply diff files as I am still relatively new to git hub and the pkp patch process.

Edward
cedavid
 
Posts: 30
Joined: Thu Jul 17, 2014 7:17 am
Location: Calgary, Alberta, Canada

Re: Notification of submission - mixed signature

Postby JasonNugent » Fri Oct 24, 2014 12:07 pm

Hi Edward,

Is it possible to check your error logs for problems during the submission process? The changes are pretty small.

If you want, you can roll back the changes you made and apply the patches with the 'patch' command:

patch -p1 patchfile.diff

You'd just need to run the first one in the base OMP directory and the second in the lib/pkp directory. You can test with 'patch --dry-run -p1 .....' to verify that it will go cleanly before actually doing it.

Regards,
Jason
JasonNugent
Site Admin
 
Posts: 894
Joined: Tue Jan 10, 2006 6:20 am

Re: Notification of submission - mixed signature

Postby cedavid » Fri Oct 24, 2014 12:17 pm

Jason,
so to roll back I delete the new changes and put back the old code or do I use a git command?

Thanks,
Edward
cedavid
 
Posts: 30
Joined: Thu Jul 17, 2014 7:17 am
Location: Calgary, Alberta, Canada

Re: Notification of submission - mixed signature

Postby cedavid » Fri Oct 24, 2014 12:22 pm

Jason,
Here is from the apache error log.

[Fri Oct 24 11:07:00 2014] [error] [client 10.70.133.250] omp: 404 Not Found, referer: http://136.159.200.88/omp/index.php/uof ... ion/wizard
[Fri Oct 24 11:07:07 2014] [error] [client 10.70.133.250] omp: 404 Not Found, referer: http://136.159.200.88/omp/index.php/uof ... ion/wizard

Edward
cedavid
 
Posts: 30
Joined: Thu Jul 17, 2014 7:17 am
Location: Calgary, Alberta, Canada

Re: Notification of submission - mixed signature

Postby JasonNugent » Fri Oct 24, 2014 12:49 pm

Hi Edward,

Since you hand-edited the files, you'll need to hand-edit them again if you want to undo your changes.

That error message is probably unrelated to this. All we're doing with these changes is passing in an option to the MailTemplate constructor telling it to not append a user's signature when it builds the message HTML body.

Regards,
Jason
JasonNugent
Site Admin
 
Posts: 894
Joined: Tue Jan 10, 2006 6:20 am

Next

Return to OMP Discussion

Who is online

Users browsing this forum: No registered users and 1 guest