OJS OCS OMP OHS

You are viewing the PKP Support Forum | PKP Home Wiki



Text boxes in review forms

Are you an Editor, Author, or Journal Manager in need of help? Want to talk to us about workflow issues? This is your forum.

Moderators: jmacgreg, michael, vgabler, John

Forum rules
This forum is meant for general questions about the usability of OJS from an everyday user's perspective: journal managers, authors, and editors are welcome to post questions here, as are librarians and other support staff. We welcome general questions about the role of OJS and how the workflow works, as well as specific function- or user-related questions.

What to do if you have general, workflow or usability questions about OJS:

1. Read the documentation. We've written documentation to cover from OJS basics to system administration and code development, and we encourage you to read it.

2. take a look at the tutorials. We will continue to add tutorials covering OJS basics as time goes on.

3. Post a question. Questions are always welcome here, but if it's a technical question you should probably post to the OJS Technical Support subforum; if you have a development question, try the OJS Development subforum.

Text boxes in review forms

Postby RickMath » Thu Feb 11, 2010 2:53 pm

We are using a review form generated in the review section of OJS.

After a reviewer has submitted a review and filled in either of two texts boxes, as an editor I cannot scroll through the text boxes. They are greyed out and the scrolls do not seem to work.

Is there some code that needs alteration.

Thanks

Rick
RickMath
 
Posts: 258
Joined: Fri Feb 27, 2009 12:30 am

Re: Text boxes in review forms

Postby RickMath » Mon Feb 15, 2010 7:58 am

After some experimentation these seem to work in Firefox but not ie7.

Is there anything I can do to change this in ie7?

Thanks

Rick
RickMath
 
Posts: 258
Joined: Fri Feb 27, 2009 12:30 am

Re: Text boxes in review forms

Postby jmacgreg » Mon Feb 15, 2010 11:49 am

Hi Rick,

I'm afraid I don't quite follow. Can you detail exactly which page you are dealing with, and which version of OJS you are using? Is this a custom review form, or the default free-form review? And how long is the review?

Cheers,
James
jmacgreg
 
Posts: 4190
Joined: Tue Feb 14, 2006 10:50 am

Re: Text boxes in review forms

Postby RickMath » Mon Feb 15, 2010 7:54 pm

James

Thanks for your reply.

We are using 2.2.2

If I log in as a section editor or as an editor to see the review form submitted by a reviewer and click on the icon for the review form this is when I cannot scrool in the test boxes. I am using a custom review form with 13 multiple choice items and two text boxes.

As I mentioned in the previous post it works in Firefox but not in Ie7.

Hope this helps to clarify the issue. Let me know what else I can provide.

Rick
RickMath
 
Posts: 258
Joined: Fri Feb 27, 2009 12:30 am

Re: Text boxes in review forms

Postby mcrider » Mon Feb 22, 2010 11:45 am

Hi Rick,

There's a patch for this available at http://pkp.sfu.ca/bugzilla/show_bug.cgi?id=3862.. If you don't feel like applying it, you can still scroll through the content of the textarea in IE by selecting some text and dragging the cursor to highlight text underneath the fold.

Cheers,
Matt
mcrider
 
Posts: 952
Joined: Mon May 05, 2008 10:29 am
Location: Vancouver, BC

Re: Text boxes in review forms

Postby RickMath » Mon Feb 22, 2010 7:42 pm

Matt

Is the updated file located in the CVS repository? If so what path is it in? Since I can't execute a patch on our server, I find it easier to just copy the contents and replace the file.

Thanks

Rick
RickMath
 
Posts: 258
Joined: Fri Feb 27, 2009 12:30 am

Re: Text boxes in review forms

Postby mcrider » Tue Feb 23, 2010 12:50 am

Hi Rick,

Patch files will have the path to the files being patched in the top of each section--The file being patched here is at templates/submission/reviewForm/reviewFormResponse.tpl.

Cheers,
Matt
mcrider
 
Posts: 952
Joined: Mon May 05, 2008 10:29 am
Location: Vancouver, BC

Re: Text boxes in review forms

Postby RickMath » Tue Feb 23, 2010 7:59 am

Matt

Thanks. I applied the new file from the CVS repository. It was the one under the OJS2 folder.

Now I getting this error when I click on the Review Response icon.

Fatal error: Call to undefined method ReviewForm::getLocalizedTitle() in /home/jamtorg/public_html/OJS/cache/t_compile/%%08^084^08439020%%reviewFormResponse.tpl.php on line 25

When I replaced the new file contents with the old one I got back to the same condition with the text boxes greyed out.

Is there something else I need to do?

Rick
RickMath
 
Posts: 258
Joined: Fri Feb 27, 2009 12:30 am

Re: Text boxes in review forms

Postby mcrider » Tue Feb 23, 2010 11:15 am

Hi Rick,

Did you try clearing your cache? Another solution I found (before I realized this was already filed as a bug) was to replace around line 21 this line:
Code: Select all
{assign var=disabled value="disabled=\"disabled\" "}

to..
Code: Select all
{assign var=disabled value="onkeypress=\"return false;\" onfocus=\"this.blur();\" "}

If clearing the cache doesn't work, I'd suggest trying out this solution.

Cheers,
Matt
mcrider
 
Posts: 952
Joined: Mon May 05, 2008 10:29 am
Location: Vancouver, BC

Re: Text boxes in review forms

Postby RickMath » Tue Feb 23, 2010 12:12 pm

Matt

I don't see any line like that in reviewFormResponse.tpl (the original file not the one in the repository)

Am I looking in the wrong place?

Clearing the cache had no impact in resolving the error in the last post.

Thanks. I must be missing something.

Rick
RickMath
 
Posts: 258
Joined: Fri Feb 27, 2009 12:30 am

Re: Text boxes in review forms

Postby mcrider » Tue Feb 23, 2010 2:36 pm

Hi Rick,

If you're using OJS 2.2.2 it should look like that.. Could you copy in the first ~30 lines of that file to make sure we're talking about the same one?

Cheers,
Matt
mcrider
 
Posts: 952
Joined: Mon May 05, 2008 10:29 am
Location: Vancouver, BC

Re: Text boxes in review forms

Postby RickMath » Tue Feb 23, 2010 7:01 pm

:D :D Matt

I looked to far down in the file.

Your fix works now.

Sorry for my blind state.

Rick
RickMath
 
Posts: 258
Joined: Fri Feb 27, 2009 12:30 am


Return to OJS Editorial Support and Discussion

Who is online

Users browsing this forum: Google [Bot] and 2 guests