OJS OCS OMP OHS

You are viewing the PKP Support Forum | PKP Home Wiki



OJS v.2 - Copyediting - is this a bug?

Are you an Editor, Author, or Journal Manager in need of help? Want to talk to us about workflow issues? This is your forum.

Moderators: jmacgreg, michael, vgabler, John

Forum rules
This forum is meant for general questions about the usability of OJS from an everyday user's perspective: journal managers, authors, and editors are welcome to post questions here, as are librarians and other support staff. We welcome general questions about the role of OJS and how the workflow works, as well as specific function- or user-related questions.

What to do if you have general, workflow or usability questions about OJS:

1. Read the documentation. We've written documentation to cover from OJS basics to system administration and code development, and we encourage you to read it.

2. take a look at the tutorials. We will continue to add tutorials covering OJS basics as time goes on.

3. Post a question. Questions are always welcome here, but if it's a technical question you should probably post to the OJS Technical Support subforum; if you have a development question, try the OJS Development subforum.

OJS v.2 - Copyediting - is this a bug?

Postby roberta_takenaka » Mon Aug 15, 2005 8:49 am

I am trying to understand the code in classes/submission/copyeditor/CopyeditorAction.inc.php at function uploadCopyeditVersion($copyeditorSubmission, $copyeditStage), where there are the lines:

Code: Select all
// Only allow an upload if they're in the initial or final copyediting
      // stages.
      if ($copyeditStage == 'initial' && ($copyeditorSubmission->getDateNotified() == null || $copyeditorSubmission->getDateCompleted() != null)) return;
      else if ($copyeditorSubmission->getDateFinalNotified() == null || $copyeditorSubmission->getDateFinalCompleted() != null) return;


Is anything missing in else if condition, like
$copyeditStage == 'final' &&
?

I think there is a bug here, because the copyeditor is allowed to upload a file, but the file can not be saved because the else if condition is true, so the return statement is executed.
roberta_takenaka
 
Posts: 14
Joined: Mon Aug 15, 2005 8:28 am
Location: Brasil

Postby kevin » Mon Aug 15, 2005 8:22 pm

Yes, that does seem to be a bug. Your suggested fix should work.

Thanks,
kevin
 
Posts: 338
Joined: Tue Oct 14, 2003 8:23 pm

Postby nfeasey » Mon Oct 31, 2005 1:19 pm

Did this issue get fixed in a subsequent release. We seem to be having the same issue in which everything seems to go ok with the upload but the file is not, in fact updated.

If this is the fix, how should it be coded??

Thanks in advance.
nfeasey
 
Posts: 9
Joined: Thu Oct 20, 2005 9:01 am

Postby asmecher » Mon Oct 31, 2005 1:53 pm

Hello,

This issue is corrected in the current version, OJS 2.0.2-1. Please check that you're using the most up-to-date version.

Regards,
Alec Smecher
Open Journal Systems
asmecher
 
Posts: 8597
Joined: Wed Aug 10, 2005 12:56 pm

Postby Guest » Mon Oct 31, 2005 1:58 pm

Thanks for you reply.

Unfortunately our version is being customized for version 2.0.1 so I hesitate to upgrade at this point as it will affect an ongoing project.

Anyway you can give me the code in question as per this post so that I can just stick the fix in for now?

It would be really appreciated if possible.

Thanks in advance.
Guest
 

Postby Guest » Mon Oct 31, 2005 2:13 pm

Hmm?

I thinking about it, I can just download the latest version and file the file in this post from the latest version and make the necessary changes.

I assume this is a safe thing to do.
Guest
 

Postby asmecher » Tue Nov 01, 2005 12:42 pm

The above change in the snippet of code should be enough to correct the issue.

You might consider downloading a patch from 2.0.1 to 2.0.2-1 (see http://pkp.sfu.ca/ojs/download/patch/) and doing a dry run (e.g. patch --dry-run -p1 < the.patch.file). It's possible that you could still perform an upgrade with minimal conflicts.

Regards,
Alec Smecher
Open Journal Systems Team
asmecher
 
Posts: 8597
Joined: Wed Aug 10, 2005 12:56 pm


Return to OJS Editorial Support and Discussion

Who is online

Users browsing this forum: No registered users and 3 guests