We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.

Bug 8772 - Fix LE/CE/Reviewer active counts
Fix LE/CE/Reviewer active counts
Status: RESOLVED FIXED
Product: OJS
Classification: Unclassified
Component: Editors
2.4.5
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-05-21 11:15 PDT by Alec Smecher
Modified: 2014-05-27 07:48 PDT (History)
0 users

See Also:
Version Reported In:
Also Affects:


Attachments
Patch against OJS 2.4.4-1 (and nearby versions) (19.70 KB, patch)
2014-05-21 11:15 PDT, Alec Smecher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Smecher 2014-05-21 11:15:34 PDT
Created attachment 4026 [details]
Patch against OJS 2.4.4-1 (and nearby versions)

See http://pkp.sfu.ca/support/forum/viewtopic.php?f=8&t=11318 for details.

There are a few problems here:
- Some inconsistency in the code
- Some deprecation warnings that can be fixed in the bargain

...but mostly this is arises from different interpretations of "complete" between the [Section]Editor's lists ("complete" means a task that was actually finished by the user in question) and the Copyeditor/Layout Editor/Proofreader's lists ("complete" means a task that was either finished or published anyway).

Suggest settling on the "published anyway" definition; this will be consistent, though will not clearly indicate to the Editor that a particular user was responsive. Going for consistency is the lesser evil IMO.

Reviewers should be excluded from this -- in the case of reviewers it's more valuable to know how many reviews the user actually finished, not including canceled or published-anyway situations.
Comment 1 Alec Smecher 2014-05-27 07:48:03 PDT
Fix LE/CE/reviewer active counts
https://github.com/pkp/ojs/commit/bdf495e7f2897fcee757a8d47c671772f33a3653