Bug 8665 - search error
search error
Status: RESOLVED FIXED
Product: OMP
Classification: Unclassified
Component: Search/Indexing
1.1.1
All All
: P3 normal
Assigned To: Alec Smecher
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-31 10:44 PDT by Bozana Bokan
Modified: 2014-04-11 15:13 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments
Patch against OMP 1.1.0 (12.78 KB, patch)
2014-04-11 14:30 PDT, Alec Smecher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bozana Bokan 2014-03-31 10:44:13 PDT

    
Comment 1 Bozana Bokan 2014-03-31 10:53:05 PDT
There are following errors when I try to search in my OMP 1.1 installation:
omp has produced an error\n  Message: WARNING: Missing argument 3 for SubmissionSearch::retrieveResults(), called in .../pages/catalog/CatalogHandler.inc.php on line 180 and defined\n  In file: .../lib/pkp/classes/search/SubmissionSearch.inc.php\n  At line: 231\n  

omp has produced an error\n  Message: WARNING: Missing argument 4 for SubmissionSearch::retrieveResults(), called in .../pages/catalog/CatalogHandler.inc.php on line 180 and defined\n  In file: .../lib/pkp/classes/search/SubmissionSearch.inc.php\n  At line: 231\n  

PHP Fatal error:  Call to undefined method Press::getUserVar() in .../lib/pkp/classes/search/SubmissionSearch.inc.php on line 320, referer: ...

:-(((
Any help?
Comment 2 Alec Smecher 2014-03-31 11:02:20 PDT
Yes... and no :(

The Fatal Error comes from pages/catalog/CatalogHandler::results. The call to...
$resultsIterator = $monographSearch->retrieveResults($press, array(null => $query));
...should be...
$resultsIterator = $monographSearch->retrieveResults($request, $press, array(null => $query));

...but this doesn't fix all the problems. It looks like https://github.com/pkp/ojs/commit/3fb3a8736c2b14311eec4aff8e450869ee106694 needs to be ported to OMP.
Comment 3 Alec Smecher 2014-03-31 12:07:02 PDT
Fix for missing request parameter
https://github.com/pkp/omp/commit/ffcc284785feae09e056560614824420e4d010b1
Comment 4 Alec Smecher 2014-03-31 12:08:01 PDT
Fix for missing request parameter
https://github.com/pkp/omp/commit/b1b8fa02c4ef2539739adb924b508789e8f05cd8
Comment 7 Alec Smecher 2014-04-11 14:03:02 PDT
Remove unnecessary re-de-duping; reintroduce necessary reference
https://github.com/pkp/omp/commit/1a2f376d3b30080ab221ea5dc80968019a4be5af
Comment 8 Alec Smecher 2014-04-11 14:22:02 PDT
Remove unnecessary re-de-duping; reintroduce necessary reference
https://github.com/pkp/omp/commit/512bed338d0a3687cf5cd112a837e1fdfd134f25
Comment 9 Alec Smecher 2014-04-11 14:30:05 PDT
Created attachment 4012 [details]
Patch against OMP 1.1.0

Bozana, this patch should fix it. (It includes all the changes mentioned here.)
Comment 10 Alec Smecher 2014-04-11 14:54:02 PDT
Added missing return
https://github.com/pkp/ojs/commit/2608b9444697b5827d83d832ab5b92f435810557
Comment 11 Alec Smecher 2014-04-11 15:13:02 PDT
Prevent index warning
https://github.com/pkp/omp/commit/8816d8df76cc950b983d550c14cb614f5f12af4a