Bug 8626 - Selecting reviewers leads to HTML wierdness
Selecting reviewers leads to HTML wierdness
Status: RESOLVED FIXED
Product: OMP
Classification: Unclassified
Component: Editors
1.1.1
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-03-19 15:18 PDT by Alec Smecher
Modified: 2014-03-27 06:13 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments
Patch against OMP 1.1.0 (574 bytes, patch)
2014-03-26 09:34 PDT, Jason Nugent
Details | Diff
Patch against OMP 1.1.0 (606 bytes, patch)
2014-03-27 06:13 PDT, Jason Nugent
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Smecher 2014-03-19 15:18:04 PDT
Selecting a reviewer to assign via the Advanced reviewer search form leads to a "span" tag in the reviewer selection field when the editor returns to the regular reviewer form.
Comment 1 Jason Nugent 2014-03-26 05:37:03 PDT
fix extraction of reviewer name
https://github.com/pkp/pkp-lib/commit/ace6d4d89b75adfb7f6059c2065005a846d648c8
Comment 2 Jason Nugent 2014-03-26 05:45:02 PDT
fix extraction of reviewer name
https://github.com/pkp/pkp-lib/commit/68e4efd076930588e3ad219bd5b5ac18a372ee94
Comment 3 Jason Nugent 2014-03-26 09:34:08 PDT
Created attachment 4007 [details]
Patch against OMP 1.1.0

patch against 1.1.0.  Run from lib/pkp sub directory.
Comment 4 Jason Nugent 2014-03-27 06:11:36 PDT
Comment on attachment 4007 [details]
Patch against OMP 1.1.0

>diff --git a/lib/pkp/js/controllers/grid/users/reviewer/AdvancedReviewerSearchHandler.js b/lib/pkp/js/controllers/grid/users/reviewer/AdvancedReviewerSearchHandler.js
>index 23d57ed..369d5e5 100644
>--- a/lib/pkp/js/controllers/grid/users/reviewer/AdvancedReviewerSearchHandler.js
>+++ b/lib/pkp/js/controllers/grid/users/reviewer/AdvancedReviewerSearchHandler.js
>@@ -66,7 +66,7 @@
> 
> 		if (reviewerId) {
> 			reviewerName = $.trim($selectedInput.parent().next().
>-					children('span').html());
>+					children('span').text());
> 
> 			// Update the hidden review id input
> 			$('#reviewerId').val(reviewerId);
>
Comment 5 Jason Nugent 2014-03-27 06:13:37 PDT
Created attachment 4008 [details]
Patch against OMP 1.1.0