We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.

Bug 8444 - Wrong file path returned for suppfiles
Wrong file path returned for suppfiles
Status: RESOLVED WONTFIX
Product: OJS
Classification: Unclassified
Component: General
2.4.x
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-07 15:39 PDT by Jen Whitney
Modified: 2013-11-29 15:47 PST (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments
Patch against OJS 2.4.2 (2.98 KB, text/plain)
2013-10-07 15:39 PDT, Jen Whitney
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jen Whitney 2013-10-07 15:39:53 PDT
Created attachment 3967 [details]
Patch against OJS 2.4.2

Calling getFilePath() on a SuppFile object returns an incorrect file path because SuppFileDAO doesn't set file stage when creating SuppFile object.

When a submission file's stage is mapped to a subdirectory, the default 'submission/original' path is used when file stage is undefined. File paths for suppfiles point here instead of the expected 'supp/' path.
Comment 1 Alec Smecher 2013-11-29 15:47:50 PST
Jen, if I understand this, it's internally consistent -- i.e. supp files are working -- but stores everything in submission/original/ instead of supp/. We've changed the model for OJS 3.0 to remove supplementary files entirely, so I'm hesitant to make a chance that'll involve moving files around during upgrade since it'll only be effective for maintenance releases.