Bug 8353 - Allow URL override of current locale
Allow URL override of current locale
Status: RESOLVED FIXED
Product: OJS
Classification: Unclassified
Component: Localization
2.4.3
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-29 11:25 PDT by Alec Smecher
Modified: 2013-09-09 14:52 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Alec Smecher 2013-07-29 11:30:02 PDT
Allow override of current locale via URL
https://github.com/pkp/ojs/commit/2a85565dae913cf67bd79ec4470e98c008ad10aa
Comment 2 Alec Smecher 2013-07-29 11:59:01 PDT
Allow locale set by URL
https://github.com/pkp/ojs/commit/f705b5d884aa3a157a560b6265d2cd865298a37d
Comment 3 Alec Smecher 2013-07-29 12:00:02 PDT
Allow locale set by URL (fix parameter name to avoid clobber)
https://github.com/pkp/ojs/commit/68de19883dbf18f14c929750dd0dc40e13b7f083
Comment 4 Alec Smecher 2013-07-29 12:09:02 PDT
Allow UI locale override via URL (OMP pre-1.1)
https://github.com/pkp/omp/commit/ed15973dbf36c9e33391f508854cabd9bc991a3a
Comment 5 Alec Smecher 2013-07-29 12:11:01 PDT
Allow UI locale override via URL (OCS pre-3.0)
https://github.com/pkp/ocs/commit/eeb4c99d8deedd5a883e012d117132837d25262f
Comment 6 Alec Smecher 2013-07-29 12:24:02 PDT
Allow UI locale override via URL (OHS pre-???)
https://github.com/pkp/harvester/commit/04ff1cc7d295dfb46f06de09de5d01e359bedbf0
Comment 8 Giovani Pieri 2013-09-06 16:12:21 PDT
Hi Alec,

A bug was introduced in Github OJS 2.4 branch. The language toggle block plugin is broken. 

I've traced it down to commit:
https://github.com/pkp/ojs/commit/2a85565dae913cf67bd79ec4470e98c008ad10aa

I believe that the assignment to $locale var is missing in line 88. Shouldn't it be "$locale = $session->getSessionVar('currentLocale');"?


Regards,
Giovani
Comment 9 Alec Smecher 2013-09-09 14:51:48 PDT
You're right, Giovani; thanks for pointing it out. See https://github.com/pkp/ojs/commit/fd24209beee0ca14db2608538bf917029db45dc8
Comment 10 Alec Smecher 2013-09-09 14:52:02 PDT
Fix missing variable assignment
https://github.com/pkp/ojs/commit/fd24209beee0ca14db2608538bf917029db45dc8