Bug 8343 - Error in highlightCopyediting
Error in highlightCopyediting
Status: RESOLVED FIXED
Product: OJS
Classification: Unclassified
Component: Editors
2.4.1
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-28 07:55 PDT by Andrea Marchitelli
Modified: 2013-07-29 09:24 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments
Proposed patch (830 bytes, application/octet-stream)
2013-07-28 07:55 PDT, Andrea Marchitelli
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Marchitelli 2013-07-28 07:55:04 PDT
Created attachment 3947 [details]
Proposed patch

In /classes/submission/sectionEditor/SectionEditorSubmission.inc.php
this check seems to be wrong 
// Check if acknowledgement is overdue for CE round 3
if ($dateCopyeditorFinalCompleted && !$dateCopyeditorFinalAcknowledged) return 'highlightCopyediting';

because the $dateCopyeditorFinalAcknowledged is not defined.
Comment 1 Andrea Marchitelli 2013-07-28 07:56:26 PDT
Discussion here:http://pkp.sfu.ca/support/forum/viewtopic.php?f=8&t=10264&p=40094#p40094
Comment 2 Alec Smecher 2013-07-29 09:23:05 PDT
Committed. Thanks, Andrea!
Comment 3 Alec Smecher 2013-07-29 09:24:02 PDT
Fixed missing variable fetch
https://github.com/pkp/ojs/commit/62c4d08d47b60a203fd1dae4cb690b9e5a94ee4d