Bug 8293 - Review & centralize NotificationManager
Review & centralize NotificationManager
Status: NEW
Product: OJS
Classification: Unclassified
Component: General
3.0b
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-11 14:39 PDT by Alec Smecher
Modified: 2013-08-06 14:12 PDT (History)
0 users

See Also:
Version Reported In:
Also Affects:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Smecher 2013-07-11 14:39:49 PDT
Now that OMP and OJS are sharing many of the workflow notifications, we risk duplicating a lot of code in classes/notification/NotificationManager.inc.php between the two apps. Much of OJS's NotificationManager is no longer relevant. Move as much as possible into lib-pkp and fix.
Comment 1 Jason Nugent 2013-07-18 07:38:02 PDT
fix role bug, section editor participant test
https://github.com/pkp/ojs/commit/b02d3d63294b3956cfcf06d4f8cb2d7b4c30dbea
Comment 2 Alec Smecher 2013-08-01 13:00:02 PDT
Clean up NotificationManager in prep for move to PKP lib
https://github.com/pkp/omp/commit/53ac622d83f4d15a6da9618e24f83671c2248fdd
Comment 3 Alec Smecher 2013-08-01 14:06:02 PDT
Deduping notification manager code
https://github.com/pkp/ojs/commit/4cae1671b150abf461b70a11700dd26e62c3327f
Comment 4 Alec Smecher 2013-08-01 14:06:02 PDT
Deduping notification manager code
https://github.com/pkp/omp/commit/3bcd1718a00820a1ac98ef151b0e34b598d587d3
Comment 5 Alec Smecher 2013-08-06 12:34:02 PDT
Share all reviews/all revisions notifications
https://github.com/pkp/pkp-lib/commit/e870798dafd4d40b32be9adcb3f1cea08eb62117
Comment 6 Alec Smecher 2013-08-06 12:35:02 PDT
Share all reviews/all revisions notifications
https://github.com/pkp/omp/commit/ffc554dee0c27e10c8dbb0f29146f7e42231d3b1
Comment 7 Alec Smecher 2013-08-06 13:38:01 PDT
Share various workflow notifications
https://github.com/pkp/pkp-lib/commit/abfb8fc836c8ea1258917b414c9358bfc3351240
Comment 8 Alec Smecher 2013-08-06 13:38:01 PDT
Share various workflow notifications
https://github.com/pkp/omp/commit/96a8100dd257fc688adeab205e42a094e82a918b
Comment 9 Alec Smecher 2013-08-06 14:12:01 PDT
Remove old notification code
https://github.com/pkp/ojs/commit/91019fa9acc48122614fe47eb17510c3b0a6a6b6
Comment 10 Alec Smecher 2013-08-06 14:12:06 PDT
Deferring the rest to beta. Still lots of probably obsolete notifications in OJS's NotificationManager, but these are upgrade concerns.