Bug 8256 - URN/DOI extracts may attempt to fetch journal initials in a language the journal doesn't support
URN/DOI extracts may attempt to fetch journal initials in a language the jour...
Status: RESOLVED FIXED
Product: OJS
Classification: Unclassified
Component: Plug-ins
2.4.3
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-12 12:44 PDT by Alec Smecher
Modified: 2013-06-12 12:58 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Smecher 2013-06-12 12:44:33 PDT
From Bozana:
> Using %j in the suffix pattern means $journal->getLocalizedSetting('initials').
> If the overall/site OAI interface is used where there is no journal context
> the LOCALE_DEFAULT is used, but a journal (in this installation) doesn't have
> to support this locale. Thus, in this case, this will be missing resp. there
> will be a %j in the DOI/URN resp. DOI/URN will be wrong. And, once saved (and
> not to mention registered) they cannot be or hardly changed any more :(
> Thus, should we maybe use $journal->getLocalizedSetting('initials',
> $journal->getPrimaryLocale()) here?

Agreed.
Comment 1 Alec Smecher 2013-06-12 12:53:02 PDT
Fix %j when site locale isn't supported by journal
https://github.com/pkp/ojs/commit/fcd2c2530e021969082b7560909fcab1a90d29df
Comment 2 Alec Smecher 2013-06-12 12:58:01 PDT
Fix %j when site locale isn't supported by journal (back-port for OJS 2.4.x)
https://github.com/pkp/ojs/commit/9372325701726a5ec0ae796a95b409a09caa15a2