Bug 8239 - Review Setup for missing language
Review Setup for missing language
Status: ASSIGNED
Product: OJS
Classification: Unclassified
Component: Journal Management
3.0
All All
: P3 normal
Assigned To: Alec Smecher
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-30 12:09 PDT by Alec Smecher
Modified: 2013-07-23 15:47 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Smecher 2013-05-30 12:09:23 PDT
Several of the Setup forms have missing locale keys, i.e. keys that need migration to lib-pkp if they're app-independent, or more likely, rewriting from OJS to be suitable for journal publication. Review setup and correct these.
Comment 1 James MacGregor 2013-07-18 11:59:55 PDT
Going through these right now and adding. Note to self or Alec: manager.languages.languageInstructions on the Website -> Languages page isn't appearing, even though it's in locale/en_US/manager.xml. Not sure how to fix that one.
Comment 2 James MacGregor 2013-07-18 12:07:28 PDT
Ditto for settings.roles.gridDescription on the Users & Roles -> Roles tab. It's in manager.xml as well.
Comment 3 James MacGregor 2013-07-18 12:10:02 PDT
adding missing setup instruction locale keys
https://github.com/pkp/pkp-lib/commit/526e6fdf5646f90324538aef2d7b518b414e9049
Comment 4 James MacGregor 2013-07-18 12:10:02 PDT
adding missing setup instruction locale keys
https://github.com/pkp/ojs/commit/7262d145a58cea5b1e39b1cf033b46ef7184452f
Comment 5 James MacGregor 2013-07-18 12:14:02 PDT
adding missing setup instruction locale keys
https://github.com/pkp/omp/commit/71262438329461bed962cac3db9a7c98dfc8a0b0
Comment 6 James MacGregor 2013-07-18 12:19:08 PDT
Hey Alec, over to you to take a look at comments 1 and 2. Once done, can you move back to me and bump to OJS 3.0? This'll be good enough for 3.0a, but I do want to take a much closer look at all languages/descriptions for 3.0.
Comment 7 Alec Smecher 2013-07-23 15:46:29 PDT
Done -- thanks, James.
Comment 8 Alec Smecher 2013-07-23 15:47:02 PDT
Fix missing locale loads
https://github.com/pkp/pkp-lib/commit/c8a1d551214acf143116843bcb4df36d4f1b4698