Bug 8144 – PayPal payments never complete with site restriction enabled

Bug 8144 - PayPal payments never complete with site restriction enabled

Summary:

PayPal payments never complete with site restriction enabled

Status:	RESOLVED FIXED

Product:	OJS
Classification:	Unclassified
Component:	Payments
Version:	2.3.9
Platform:	All All

Importance:	P3 normal
Assigned To:	Michael Felczak

URL:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-03-05 11:57 PST by Michael Felczak
Modified:	2013-04-24 13:52 PDT (History)
CC List:	2 users (show)

See Also:
Version Reported In:	2.3.8
Also Affects:	OCS 2.3.5, OJS 2.4.2, OMP 1.0

Attachments
Patch against OJS 2.3.8 (apply against lib/pkp; should work with 2.3.7, 2.3.6, etc.) (389 bytes, patch) 2013-03-05 12:45 PST, Michael Felczak	Details \| Diff
Patch against OJS 2.4.2 (apply against lib/pkp; should work with 2.4.1, 2.4.0, etc.) (409 bytes, patch) 2013-03-05 12:45 PST, Michael Felczak	Details \| Diff
Patch against OCS 2.3.5 (apply against lib/pkp; should work with 2.3.4, 2.3.3, etc.) (287 bytes, patch) 2013-03-05 12:46 PST, Michael Felczak	Details \| Diff
Patch against OMP 1.0 (apply against lib/pkp) (409 bytes, patch) 2013-03-05 12:48 PST, Michael Felczak	Details \| Diff
Patch against OJS 2.3.8 (should work with 2.3.7, 2.3.6, etc.) (405 bytes, patch) 2013-04-24 13:49 PDT, Alec Smecher	Details \| Diff
Patch against OJS 2.4.2 (should work with 2.4.1, 2.4.0, etc.) (303 bytes, patch) 2013-04-24 13:50 PDT, Alec Smecher	Details \| Diff
Patch against OCS 2.3.5 (should work with 2.3.4, 2.3.3, etc.) (303 bytes, patch) 2013-04-24 13:51 PDT, Alec Smecher	Details \| Diff
Patch against OMP 1.0 (425 bytes, patch) 2013-04-24 13:51 PDT, Alec Smecher	Details \| Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Felczak 2013-03-05 11:57:57 PST

Setup => Management => Additional Site and Article Access Restrictions

If the JM enables "Users must be registered and log in to view the journal site" then arriving PayPal payment IPN requests are mutely ignored and payments are never recorded as completed.

Comment 1 Michael Felczak 2013-03-05 12:10:03 PST

PayPal payments never complete with site restriction enabled
https://github.com/pkp/pkp-lib/commit/4ab2633103a9e68347205e365c9992947fc53e11

Comment 2 Michael Felczak 2013-03-05 12:15:01 PST

PayPal payments never complete with site restriction enabled
https://github.com/pkp/pkp-lib/commit/c047f617cb6676f6d54707b1ac58c035cba82515

Comment 3 Michael Felczak 2013-03-05 12:20:03 PST

PayPal payments never complete with site restriction enabled
https://github.com/pkp/pkp-lib/commit/54d861ee9cd0759eaaa631a92100098bbbc38257

Comment 4 Michael Felczak 2013-03-05 12:30:03 PST

PayPal payments never complete with site restriction enabled
https://github.com/pkp/pkp-lib/commit/2e5d956d9ff702f268c75d093e4061df8921c1b7

Comment 5 Alec Smecher 2013-03-05 12:37:00 PST

Thanks, Michael. Also added this to the recommended patches list for 2.4.2.

Comment 6 Michael Felczak 2013-03-05 12:45:02 PST

PayPal payments never complete with site restriction enabled
https://github.com/pkp/pkp-lib/commit/8e3c880a7a056a89cb5c794a41eefba9431c286c

Comment 7 Michael Felczak 2013-03-05 12:45:13 PST

Created attachment 3915 [details]
Patch against OJS 2.3.8 (apply against lib/pkp; should work with 2.3.7, 2.3.6, etc.)

Comment 8 Michael Felczak 2013-03-05 12:45:58 PST

Created attachment 3916 [details]
Patch against OJS 2.4.2 (apply against lib/pkp; should work with 2.4.1, 2.4.0, etc.)

Comment 9 Michael Felczak 2013-03-05 12:46:49 PST

Created attachment 3917 [details]
Patch against OCS 2.3.5 (apply against lib/pkp; should work with 2.3.4, 2.3.3, etc.)

Comment 10 Michael Felczak 2013-03-05 12:48:00 PST

Created attachment 3918 [details]
Patch against OMP 1.0 (apply against lib/pkp)

Comment 11 Michael Felczak 2013-03-05 12:56:39 PST

Thanks Alec.

Also added as recommended patch for OJS 2.3.8, OCS 2.3.5, OMP 1.0 ...

Comment 12 Alec Smecher 2013-04-24 13:49:30 PDT

Created attachment 3925 [details]
Patch against OJS 2.3.8 (should work with 2.3.7, 2.3.6, etc.)

Comment 13 Alec Smecher 2013-04-24 13:50:24 PDT

Created attachment 3926 [details]
Patch against OJS 2.4.2 (should work with 2.4.1, 2.4.0, etc.)

Comment 14 Alec Smecher 2013-04-24 13:51:08 PDT

Created attachment 3927 [details]
Patch against OCS 2.3.5 (should work with 2.3.4, 2.3.3, etc.)

Comment 15 Alec Smecher 2013-04-24 13:51:59 PDT

Created attachment 3928 [details]
Patch against OMP 1.0

Comment 16 Alec Smecher 2013-04-24 13:52:14 PDT

(Patches corrected to avoid having to apply in lib/pkp subdirectory.)