Bug 8116 - Bug in _getUnfilteredEditorSubmissions
Bug in _getUnfilteredEditorSubmissions
Status: RESOLVED FIXED
Product: OJS
Classification: Unclassified
Component: Editors
2.4.2
All All
: P3 normal
Assigned To: PKP Support
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-12 14:38 PST by Alec Smecher
Modified: 2013-02-12 14:45 PST (History)
0 users

See Also:
Version Reported In:
Also Affects:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Smecher 2013-02-12 14:38:56 PST
From Bozana:

> 
> I think this part of code in the function _getUnfilteredEditorSubmissions in
> classes/submission/editor/EditorSubmissionDAO.inc.php is now wrong:
>       if ($editorId) {
>           $searchSql .= ' AND ed.user_id = ?';
>           $params[] = $editorId;
>       }
> 
> The 'ed' is only there if somebody searches for an editor. If somebody want's
> to filter by an editor there is an error 'unknown column ed.user_id'. You can
> see it for example if you (as editor) go to submissions archives and try to
> filter by 'me' ('assigned to me'). Thus, I think here there should be:
>       if ($editorId) {
>           $searchSql .= ' AND ea.editor_id = ?';
>           $params[] = $editorId;
>       }
Comment 1 Alec Smecher 2013-02-12 14:45:02 PST
Editor search bug
https://github.com/pkp/ojs/commit/7178b88a7b4f6581e9321b687886af91cabe60ba
Comment 2 Alec Smecher 2013-02-12 14:45:03 PST
Editor search bug
https://github.com/pkp/ojs/commit/3f6daf9d99a19385cc69d2f3e11acf25aee2a025