Bug 8091 - JS Form handler doesn't work with onSubmit event declared inside form html
JS Form handler doesn't work with onSubmit event declared inside form html
Status: RESOLVED FIXED
Product: OJS
Classification: Unclassified
Component: User Interface
3.0a
All All
: P3 normal
Assigned To: beghelli
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-22 09:34 PST by beghelli
Modified: 2013-07-01 08:29 PDT (History)
1 user (show)

See Also:
Version Reported In:
Also Affects:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description beghelli 2013-01-22 09:34:04 PST
And it shouldn't. We already have options to ask for a confirmation if we use our formButtons.tpl. We have to make sure that we are porting things completely, otherwise strange things like this can happen. This means passing any js actions that might be assigned to the old OJS buttons to the current structure (using the template as I said or, if it's a more specialized action, using a specialized form handler for that).

You can check the problem editing an issue, as editors for example, and trying to save it (editor/issueToc/#issueId). The js confirmation is shown twice. (maybe you will have to find another example, I will revert the use of the FormHandler for this specific case because it is breaking one of our tests).
Comment 1 Alec Smecher 2013-06-28 10:31:33 PDT
Bruno, OJS no longer uses onSubmit anywhere in its codebase (the issue management stuff, for example, has been refactored). Can I close this bug? You mentioned reverting a test.
Comment 2 beghelli 2013-06-28 12:39:22 PDT
I think we can close this one. If we are going to fix all the tests for ojs again than I think we need another bug entry.
Comment 3 Alec Smecher 2013-07-01 08:29:09 PDT
Thanks, Bruno.