PKP Bugzilla – Bug 8091
JS Form handler doesn't work with onSubmit event declared inside form html
Last modified: 2013-07-01 08:29:09 PDT
We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.
And it shouldn't. We already have options to ask for a confirmation if we use our formButtons.tpl. We have to make sure that we are porting things completely, otherwise strange things like this can happen. This means passing any js actions that might be assigned to the old OJS buttons to the current structure (using the template as I said or, if it's a more specialized action, using a specialized form handler for that).
You can check the problem editing an issue, as editors for example, and trying to save it (editor/issueToc/#issueId). The js confirmation is shown twice. (maybe you will have to find another example, I will revert the use of the FormHandler for this specific case because it is breaking one of our tests).
Bruno, OJS no longer uses onSubmit anywhere in its codebase (the issue management stuff, for example, has been refactored). Can I close this bug? You mentioned reverting a test.
I think we can close this one. If we are going to fix all the tests for ojs again than I think we need another bug entry.